[80_6] Improving Radical Box Typesetting #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-liii
reviewed
Oct 6, 2024
| Y+= fn->sqrt_degree_rise_percent * sqrtb->h () / 100; | ||
| M = fn->sqrt_kern_after_degree; | ||
| sep= 0; | ||
| b2->x1-= fn->sqrt_kern_before_degree; |
There was a problem hiding this comment.
a bit confused on this parameter
There was a problem hiding this comment.
The OpenType math table requires spacing both before and after the degree symbol. In the case of b2->x1, the front spacing is added, while M represents the distance from the back of the symbol to the radical. According to the specification, the height of the degree symbol is raised by a fixed proportion of the height of the radical.
|
The rule of the radical box rendered in Fira Math font should be fixed |
da-liii
reviewed
Oct 6, 2024
| @@ -109,6 +109,13 @@ font_rep::copy_math_pars (font fn) { | |||
| frac_denom_disp_shift_down = fn->frac_denom_disp_shift_down; | |||
| frac_denom_gap_min = fn->frac_denom_gap_min; | |||
| frac_denom_disp_gap_min = fn->frac_denom_disp_gap_min; | |||
| sqrt_ver_gap = fn->sqrt_ver_gap; | |||
| sqrt_ver_disp_gap = fn->sqrt_ver_disp_gap; | |||
| sqrt_rule_thickness = fn->sqrt_rule_thickness; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improving Fraction Box Typesetting.
Why
For some opentype math font, math table gives more precise information about typesetting radical.
How to test your changes?
Open
devel/80_6.tmu.It is evident that the Asana Math and Fira Math opentype fonts have undergone changes, with significant adjustments in the spacing and positioning before and after the degree symbol. In contrast, the latter two hardcoded opentype fonts have remained unchanged.
Before:
After:
