Add dev deploy workflow

[parth-07]

This PR adds github workflow for automatic deployment to development server on encountering trigger command in the PR comments.

Trigger command: @github deploy

Github action bot will give rocket reaction to the comment on encountering trigger command, and then if the command is given by a valid user, initiates deployment

Closes #12

[parth-07]

@manorit2001 Can you please check why deploy isn't triggering deployment event.

[manorit2001]

@manorit2001 Can you please check why deploy isn't triggering deployment event.

Ah, I just checked. It seems that the project is not that maintained anymore
https://github.com/helaili/deploy

Test and staging environment are abandoned as per this which is causing the issues ig. Let's try to find some other similar project then

[manorit2001]

and if not found, we can resort to this ig

[parth-07]

This also seems promising, https://github.com/marketplace/actions/pull-request-comment-trigger, we can perhaps trigger deployment using comment triggers with this.

[manorit2001]

This also seems promising, https://github.com/marketplace/actions/pull-request-comment-trigger, we can perhaps trigger deployment using comment triggers with this.

If we can change settings so that only collaborators can trigger it, then it seems good

[parth-07]

deploy

[manorit2001]

deploy

[manorit2001]

@parth-07 it works!

[parth-07]

@manorit2001 yayy :)

[manorit2001]

things are being deployed even if we comment in issue, prevent that

[manorit2001]

it seems like i can't write the work dep-loyed anymore 😂

[parth-07]

@github deploy

[parth-07]

@manorit2001 Yes, @github deploy works, so I guess we will be tagging github everytime while deploying xD

[manorit2001]

deployed again 😂

[manorit2001]

and try to prevent running of workflow from issues altogether if possible

[parth-07]

@manorit2001 Ideally, it should just match if command is present at start of the comment. But alas, it checks the entire comment body.

[manorit2001]

@manorit2001 Ideally, it should just match if command is present at start of the comment. But alas, it checks the entire comment body.

@github don't deploy

just a check xD

EDIT: ah, atleast it doesn't match things like a subsequence, that's a plus

[parth-07]

and try to prevent running of workflow from issues altogether if possible

This seems more difficult, issues_comment works for both issues and pull requests, it seems internally github treats pull requests as issues only.

[parth-07]

EDIT: ah, atleast it doesn't match things like a subsequence, that's a plus

Yeah seriously, that would be a nighmare xD

[manorit2001]

This seems more difficult, issues_comment works for both issues and pull requests, it seems internally github treats pull requests as issues only.

src: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#issue_comment
we can add this if condition ig

on: issue_comment

jobs:
  pr_commented:
    # This job only runs for pull request comments
    name: PR comment
    if: ${{ github.event.issue.pull_request }}
    runs-on: ubuntu-latest
    steps:
      - run: |
          echo "Comment on PR #${{ github.event.issue.number }}"

  issue_commented:
    # This job only runs for issue comments
    name: Issue comment
    if: ${{ !github.event.issue.pull_request }}
    runs-on: ubuntu-latest
    steps:
      - run: |
          echo "Comment on issue #${{ github.event.issue.number }}"

[parth-07]

This seems more difficult, issues_comment works for both issues and pull requests, it seems internally github treats pull requests as issues only.

src: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#issue_comment
we can add this if condition ig

on: issue_comment

jobs:
  pr_commented:
    # This job only runs for pull request comments
    name: PR comment
    if: ${{ github.event.issue.pull_request }}
    runs-on: ubuntu-latest
    steps:
      - run: |
          echo "Comment on PR #${{ github.event.issue.number }}"

  issue_commented:
    # This job only runs for issue comments
    name: Issue comment
    if: ${{ !github.event.issue.pull_request }}
    runs-on: ubuntu-latest
    steps:
      - run: |
          echo "Comment on issue #${{ github.event.issue.number }}"

Workflow will still be triggered in these cases, right ? Job will be skipped though.

[manorit2001]

Workflow will still be triggered in these cases, right ? Job will be skipped though.

Ah, makes sense, but the authentication job is still being run, we can skip that also when running things on issue

[parth-07]

Workflow will still be triggered in these cases, right ? Job will be skipped though.

Ah, makes sense, but the authentication job is still being run, we can skip that also when running things on issue

Yes agreed, that step should be skipped.

[parth-07]

@github deploy

[parth-07]

@github deploy

[manorit2001]

Hi, The deployment works fine but I can see some warnings in Github Actions. I know they won't matter much as deployment works fine but I would at least like you to look into it once if you can fix them

[parth-07]

Hi, The deployment works fine but I can see some warnings in Github Actions. I know they won't matter much as deployment works fine but I would at least like you to look into it once if you can fix them

Those warnings cannot be removed, they are due to using octokit for making API requests, they are mentioned in the documentation page too https://github.com/octokit/request-action#warnings

[manorit2001]

Those warnings cannot be removed, they are due to using octokit for making API requests, they are mentioned in the documentation page too https://github.com/octokit/request-action#warnings

Ah, seems right, cool

[manorit2001]

LGTM