Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video_max_size doesn't respect offscreen_api flag #287

Closed
timeu opened this issue Feb 14, 2024 · 0 comments · Fixed by #288
Closed

video_max_size doesn't respect offscreen_api flag #287

timeu opened this issue Feb 14, 2024 · 0 comments · Fixed by #288

Comments

@timeu
Copy link
Contributor

timeu commented Feb 14, 2024

Due to the way xpra-html5 initializes the client, the video_max_size is always set to [1024, 768] regardless of the offscreen_api setting.

The video_max_size value is set here depending on the offscreen_api setting.
However the offscreen_api setting is set at a later time.

This leads to unnecessary downsampling/sizing when using the xpra-html5 client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update video_max_size when offscreen_api is enabled CLIP-HPC/xpra-html5
1 participant
@timeu