-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
figure out the correct dimensions masks for codecs #3359
Comments
The fix above was another lazy fix - self.out_height[i] = (int) (dst_height * dst.height_mult[i])
- self.out_stride[i] = roundup((int) (dst_width * dst.width_mult[i]), 16)
+ self.out_height[i] = ceil(dst_height * dst.height_mult[i])
+ self.out_stride[i] = roundup(ceil(dst_width * dst.width_mult[i]), 16) |
by honouring the rowstride specified, also prettify the output
As per the commit above, Still to test:
|
This may have caused the crashes in #3706 (comment) |
The lazy approach we use is to clamp the dimensions using:
But some csc modules and video encoders may well be able to handle odd dimensions correctly, especially when handling
RGB
input directly.The text was updated successfully, but these errors were encountered: