docs: Add sleep in README #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
SteveLauC
reviewed
Sep 4, 2024
| @@ -34,6 +34,8 @@ async fn main() -> Result<()> { | |||
| let content = fetch | |||
| // Retry with exponential backoff | |||
| .retry(ExponentialBuilder::default()) | |||
| // Sleep implementation, required if no feature has been enabled | |||
| .sleep(tokio::time::sleep) | |||
There was a problem hiding this comment.
Should we add this to the blocking retry example as well? i.e., something like:
.sleep(std::thread::sleep)
Xuanwo
pushed a commit
that referenced
this pull request
Sep 4, 2024
### What does this PR do Based on the [discussion](#131 (comment)), mention `sleep()` in the blocking retry examples. Added to examples in both `README.md` and `lib.rs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.