-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gloo-timers
with futures-timer
#154
base: main
Are you sure you want to change the base?
Conversation
- Migrated Sleeper implementation from `gloo-timers` to async runtime-agnostic `futures-timer` - Adjusted feature flags and updated dependencies to reflect this change, ensuring seamless functionality across different environments: - `gloo-timers-sleep` feature kept for backwards compatibility, it will imply the automatically `futures-timer-sleep` - if `wasm32` architecture is detected, it automatically enables the `gloo-timers` feature on `futures-timer` crate to ensure WASM compatibility. Closes Xuanwo#153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. But I prefer to keep gloo-timers
feature as is and only add a new feature for futures-timer
.
Thanks for the comments. I will improve it. |
@Xuanwo I pushed some changes. Let me know if a type alias for |
Thank you for your efforts; I prefer to leave them unchanged. |
What
Migrated Sleeper implementation from
gloo-timers
to async runtime-agnosticfutures-timer
Adjusted feature flags and updated dependencies to reflect this change, ensuring seamless functionality across different environments:
gloo-timers-sleep
feature kept for backwards compatibility, it will imply the automaticallyfutures-timer-sleep
if
wasm32
architecture is detected, it automatically enables thegloo-timers
+wasm-bindgen
features onfutures-timer
crate to ensure WASM compatibility.Closes #153