chore: Remove unnecessary optional feature selectors #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry for nitpicking, I was wondering what the question marks mean in the feature deps and after learning about their meaning it occured to me that they are actually not necessary here, since the tokio respectively gloo-timers crate is added as a dependency in the same feature. Hope I understood it correctly, happy to learn more about this syntax.
Xuanwo
changed the title
Xuanwo
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Thank you @wackazong, you are correct!
The "package-name/feature-name" syntax will also enable package-name if it is an optional dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for nitpicking, I was wondering what the question marks mean in the feature deps and after learning about their meaning it occured to me that they are actually not necessary here, since the tokio respectively gloo-timers crate is added as a dependency in the same feature. Hope I understood it correctly, happy to learn more about this syntax.