Add jitter to constant backoff #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change dependencies to reduce compilation time a little. Fell free to ask revert some changes. |
balroggg
commented
Feb 24, 2023
|
|
||
| let dur = it.next().unwrap(); | ||
| fastrand::seed(7); | ||
| assert!(dur > Duration::from_secs(1)); |
There was a problem hiding this comment.
It's hard to test random things, this should be something like delay <= dur < delay + rng
There was a problem hiding this comment.
Are you willing to start a new PR for this?
There was a problem hiding this comment.
Maybe for unit test is enough. I will try to find a better solution, but I'm not sure.
balroggg
commented
Feb 24, 2023
| @@ -96,14 +107,18 @@ impl Iterator for ConstantBackoff { | |||
| type Item = Duration; | |||
|
|
|||
| fn next(&mut self) -> Option<Self::Item> { | |||
| let delay = || match self.jitter { | |||
| true => self.delay + self.delay.mul_f32(fastrand::f32()), | |||
There was a problem hiding this comment.
In default case it's a little strange to set delay(1s) + jitter(1s in some cases), so double the main delay. But maybe it's ok.
There was a problem hiding this comment.
We can add jitter range for user in the future, let's merge first.
|
Thanks a lot! |
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstantBackoffrandtofastrandfuturestofutures-coreFix #37