Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document tokio::time::sleep usage #66

Merged
merged 1 commit into from
Oct 27, 2023
Merged

docs: Document tokio::time::sleep usage #66

merged 1 commit into from
Oct 27, 2023

Conversation

vriesk
Copy link
Contributor

@vriesk vriesk commented Oct 27, 2023

No description provided.

@Xuanwo Xuanwo changed the title Document tokio::time::sleep usage. docs: Document tokio::time::sleep usage Oct 27, 2023
Xuanwo
Xuanwo approved these changes Oct 27, 2023
View reviewed changes
Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit b218b37 into Xuanwo:main Oct 27, 2023
7 checks passed
@tisonkun
Copy link

@Xuanwo If we have a hard dependency on tokio's Sleep, it seems that this library depends on a running Tokio runtime?

@Xuanwo
Copy link
Owner

Xuanwo commented Nov 22, 2023

@Xuanwo If we have a hard dependency on tokio's Sleep, it seems that this library depends on a running Tokio runtime?

Yes, backon requires to run inside tokio runtime for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vriesk @tisonkun @Xuanwo