Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wasm-compatible sleep if compiled for wasm32 #92

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Use wasm-compatible sleep if compiled for wasm32 #92

merged 7 commits into from
Aug 22, 2024

Conversation

wackazong
Copy link
Contributor

No description provided.

@Xuanwo
Copy link
Owner

Xuanwo commented Aug 22, 2024

Thanks a lot for this PR but we don't have test for wasm target yet. Would you like to add an action for it first? (Maybe in seperate PR)

@wackazong wackazong changed the title Use wasm-compatible sleep if comiled for wasm32 Use wasm-compatible sleep if compiled for wasm32 Aug 22, 2024
Xuanwo
Xuanwo reviewed Aug 22, 2024
View reviewed changes
src/lib.rs Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Aug 22, 2024
View reviewed changes
Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@wackazong
Copy link
Contributor Author

Sorry, I mixed up some commits and now it all landed in the same pull request. Please excuse the confusion. I included testing in wasm32-unknown-unknown now with wasm-pack. All unit tests are run.

Blocking retry is excluded on WASM because it will block all execution.

The Github action will also run the WASM tests.

@Xuanwo Xuanwo merged commit 3ec2da9 into Xuanwo:main Aug 22, 2024
8 checks passed
@Xuanwo
Copy link
Owner

Xuanwo commented Aug 22, 2024

Sorry, I mixed up some commits and now it all landed in the same pull request. Please excuse the confusion. I included testing in wasm32-unknown-unknown now with wasm-pack. All unit tests are run.

Blocking retry is excluded on WASM because it will block all execution.

The Github action will also run the WASM tests.

Thanks a lot!

@elsirion elsirion mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackazong @Xuanwo