Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse skill levels with base 10 #45

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Parse skill levels with base 10 #45

merged 1 commit into from
Nov 17, 2020

Conversation

hkdobrev
Copy link
Contributor

@XuluWarrior
Copy link
Owner

Hi @hkdobrev

Thanks for your PRs.

Out of curiosity, did you actually come across an issue with ambiguous basing? Or is this just a linting fix?

@XuluWarrior XuluWarrior merged commit 5f664cb into XuluWarrior:master Nov 17, 2020
@hkdobrev
Copy link
Contributor Author

This is a linting fix, indeed. It's not that hard to reproduce, though. If you just put a 0 in front it would be counted as an octal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuluWarrior XuluWarrior XuluWarrior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkdobrev @XuluWarrior