Add "Get & Install Cert" button (steam only) #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xzandro
requested changes
Feb 17, 2024
There was a problem hiding this comment.
This looks good so far, except two points. I did have one issue though, the first time starting SWEX and hitting the new Get & install button which stated (node:31412) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open 'C:\SWEX\cert\cert_windows.p12'
I was not able to replicate this a second time though, even when starting fresh, hmm.
Additionally, we should hide this button if not in steam mode, but you already made it that way.
Co-authored-by: Sandro <xzandrolp@gmail.com>
Xzandro
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether the button should be visible in non-steam mode or not