Sherlock fix https://github.com/sherlock-audit/2023-03-Y2K-judging/issues/163

[3xHarry]

No description provided.

[IAm0x52]

Needs additional changes. This will revert if diff is too high due to underflow in L412

[3xHarry]

@IAm0x52 position is validated to be in profit at this poiunt, meaning that entitledAmount will always be greater than shares.

[IAm0x52]

@3xHarry Highly profitable epochs could underflow here since diffInAssets can be greater than queue[index].assets. I.e. entitled amount = 200 and assets = 99. diff = 101 and 99 - 101 will underflow. That edge case would break rollover functionality. Mitigation would be complex so maybe better to just acknowledge and accept the risk

[3xHarry]

@IAm0x52 issues does not exist in later PR, see permalink:

Earthquake/src/v2/Carousel/Carousel.sol

Lines 422 to 426 in 5cb2890

	uint256 originalDepositValue = queue[index].shares -
	previewAmountInShares(
	queue[index].epochId,
	(entitledAmount - queue[index].shares) // subtract profit from share value
	);

Here i convert profit in nominal terms back to shares which is lower than nominal terms of entitledAmount
shares == entitledAmount