Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sherlock fix https://github.com/sherlock-audit/2023-03-Y2K-judging/issues/418 #133

Merged
merged 3 commits into from
May 10, 2023
Merged

Sherlock fix https://github.com/sherlock-audit/2023-03-Y2K-judging/issues/418 #133

merged 3 commits into from
May 10, 2023

Conversation

3xHarry
Copy link
Contributor

@3xHarry 3xHarry commented Apr 10, 2023

No description provided.

@3xHarry 3xHarry mentioned this pull request Apr 11, 2023
Open
IAm0x52
IAm0x52 reviewed May 5, 2023
View reviewed changes
Copy link

@IAm0x52 IAm0x52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs additional changes. This still doesn't address the issue of minting 0 because if assets == relayerFee then it will still mint 0. Should instead be:

if (queue[index].assets <= relayerFee) {

IAm0x52
IAm0x52 approved these changes May 8, 2023
View reviewed changes
Copy link

@IAm0x52 IAm0x52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. It is no longer possible to mint 0

@3xHarry 3xHarry merged commit 53438f4 into sherlock-fix-8 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAm0x52 IAm0x52 IAm0x52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3xHarry @IAm0x52