Updated Drum Track Angle + Vocal Styling #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EliteAsian123
commented
Apr 16, 2023
EliteAsian123
commented
- New Track angle (Rock Band 4)
- Track elements got repositioned
- Fixed Lyric line color
- Changed Current Lyric being singed to the same color as the line
- Repositioned the Combo Meter, Performance Text and Overdrive for Vocals
- Changed Overdrive fill color
- Added lightning in the track camera so the notes get shiny as they get closer
- New Track angle (Rock Band 4) - Track elements got repositioned - Fixed Lyric line color - Changed Current Lyric being singed to the same color as the line - Repositioned the Combo Meter, Performance Text and Overdrive for Vocals - Changed Overdrive fill color - Added lightning in the track camera so the notes get shiny as they get closer
EliteAsian123
added a commit
that referenced
this pull request
Apr 17, 2023
* add note shader graph for animation * Add Kadu's new note models. Update materials/shader * Update error in MeshRenderer * move materials to material folder * update shadergraph, move materials * Update Note_Middle.mat * fix improper material color for cymbals * lessen bloom and update shader contrast * New Multiplier Meter * New Notes! * Update Note Shader, include Track Angle change from #74 (#76) * Move SourceToGameName from Utils to SongInfo * Correct a couple crefs * Make SP be awarded on hitting last note of phrase * Made "chartIndex" names more clear * Implement methods for retrieving and loading sources * Turn default sources pattern into a dictionary * Add FetchEverything method to SongLibrary * Add separate bool for when the song library is loading Allows resetting the progress bar if multiple tasks are being done in succession * Add text description for the current loading task * Update ShaderGraph for notes * include track angle merge from #74 * add new highway textures from Kadu * Split `SongInfo` source stuff to partial class --------- Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> * Fix Vocal Track UI Changes Merge Conflicts with 'new-graphics' (#84) * Fix Vocal Track UI Changes Merge Conflicts with 'new-graphics' * Implement Riley's "Add strum leniency..." PR #83 * New Track Graphics (sunburst and new highways) and More Vocal UI Improvements (#90) * Fix Vocal Track UI Changes Merge Conflicts with 'new-graphics' * Implement Riley's "Add strum leniency..." PR #83 * More Vocal UI Improvements * More Vocal UI Improvements New glow fx on needles, color changes on harmonies, new fonts, etc * Fix Merge Conflicts * Fixed warnings and problem with songinfo sources * Fix anchoring removal * New Track Graphics stuff * Update starpower burst code * New graphics polish * Even prettier stuff - Track Lighting, notes, track angle, multiplier sunburst (#98) * More visual stuff and new cymbal textures/angle * Fix Cymbal Textures * Even prettier stuff - Track Lighting, notes, track angle, multiplier sunburst * Track Angle Adjustments and sizing RB4-like * Added "Notes" Layer * Properly adjusted fret positions * Vocal track polish * Font stuff * Better notes * Pro guitar in new graphics * Adjusted Gem shaders and Default Hit Window (#105) * New kick model * Fixed guitar notes * Changed cymbal scale * PURPLE * Updated Drum Track Angle + Vocal Styling (#107) - New Track angle (Rock Band 4) - Track elements got repositioned - Fixed Lyric line color - Changed Current Lyric being singed to the same color as the line - Repositioned the Combo Meter, Performance Text and Overdrive for Vocals - Changed Overdrive fill color - Added lightning in the track camera so the notes get shiny as they get closer Co-authored-by: Kadu Waengertner <87105274+kaduwaengertner@users.noreply.github.com> * Fixed other instruments * Track shader adjustments * Protar stuff * Small adjustments --------- Co-authored-by: jnack <55568980+jnackmclain@users.noreply.github.com> Co-authored-by: Mia Berth <miaberthrage@gmail.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> Co-authored-by: Kadu Waengertner <87105274+kaduwaengertner@users.noreply.github.com>
Purplo-cf
pushed a commit
to Purplo-cf/YARG
that referenced
this pull request
May 14, 2024
…/text events (YARC-Official#107) * make readers choose/autodetect midi encoding * RBCONs are latin1 regardless of DTA encoding * make strict UTF-8 encoding static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.