Retrieve song sources from the Clone Hero sources list #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows resetting the progress bar if multiple tasks are being done in succession
Purplo-cf
pushed a commit
to Purplo-cf/YARG
that referenced
this pull request
May 14, 2024
) * Enable nullable analysis globally for YARG.Core * Add PolySharp for attribute polyfills * Fix nullable warnings in Moonscraper * Fix nullable warnings in YARG.Core.Extensions * Fix nullable warnings in YARG.Core.Game * Fix nullable warnings in YARG.Core.Chart * Fix nullable warnings in YARG.Core.Engine * Fix nullable warnings in YARG.Core.Replays * Fix nullable warnings in YARG.Core.Song
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sources are loaded at startup after songs have been loaded. The previous hard-coded list of sources remains as a fallback for sources that don't exist in the CH list, since I noticed some are missing. Instead of a switch expression, it's now a dictionary.
The loading screen can now have the progress bar reach completion and reset multiple times, i.e. for multiple separate tasks, and the current task is shown below the progress bar.