Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Countdown rework #825

Merged
merged 11 commits into from
Aug 3, 2024
Merged

Countdown rework #825

merged 11 commits into from
Aug 3, 2024

Conversation

Purplo-cf
Copy link
Contributor

Top-level changes for countdown rework. Unity elements that are no longer necessary have been removed

@Purplo-cf Purplo-cf changed the base branch from master to engine-refactor July 14, 2024 21:56
RileyTheFox
RileyTheFox reviewed Jul 19, 2024
View reviewed changes
Assets/Script/Gameplay/HUD/CountdownDisplay.cs Outdated

[Space]
[SerializeField]
private CanvasGroup _canvasGroup;

private Coroutine _currentCoroutine;

private int _measuresLeft;
private bool _displayState;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this boolean could use a slightly more clear name personally. I had to look at where the value is set to understand what it was. Something like _displayActive would be better I think

RileyTheFox
RileyTheFox reviewed Jul 19, 2024
View reviewed changes
Assets/Script/Gameplay/HUD/CountdownDisplay.cs Outdated
@@ -69,11 +48,13 @@ public void ForceReset()

private void ToggleDisplay(bool newState)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If going through with the state variable rename, this should also be bool active or something.

RileyTheFox
RileyTheFox reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@RileyTheFox RileyTheFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the small comments, looks good. I think for some extra customisation we could have a setting to change the display into a seconds countdown instead of measures? I know some people prefer a countdown in seconds, and Clone Hero has this option too, so it would be nice to have here.

Display setting should default to measures and have the option to change it to seconds.

@RileyTheFox
Copy link
Collaborator

@EliteAsian123 @kaduwaengertner what do you think regarding the suggestion above?

@EliteAsian123
Copy link
Member

I'm always for customization 👍

@kaduwaengertner
Copy link
Member

I like the idea

@Purplo-cf
Copy link
Contributor Author

Purplo-cf commented Jul 20, 2024 •
edited
Loading

The new setting and the requested fixes are in. This will need the latest countdown-rework-core changes to run.

As far as the engine is concerned, the last measure of a countdown is always the point where overstrum/overhit detection is turned back on, regardless of the display style that you choose.

@EliteAsian123
Copy link
Member

Ah shoot wait, I'm dumb. I made some changes to the countdown prefab on engine-refactor because I didn't see that this PR changes those.

Essentially I just made sure to change all Transforms to RectTransforms on the prefab and removed the scaling on the transforms as that's bad practice. I'll revert the changes on the main branch to prevent potentially broken prefabs from merging.

@Purplo-cf
Copy link
Contributor Author

Purplo-cf commented Jul 29, 2024 •
edited
Loading

No worries! I did a rebase this morning to double check that everything still looked okay. Only had to make a few small adjustments

RileyTheFox
RileyTheFox requested changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@RileyTheFox RileyTheFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues I've noticed:

Something has corrupted and the lyric bar is just a white box now. I got a warning in Unity when checking out the branch "Broken text PPtr in file". It was referencing fileID 6635242913724598267 which is found as the m_Father in some places in CountdownDisplay.prefab

image

Also in practice mode, if you select a section that occurs after a countdown earlier in the song, it will show the last part of the countdown. However this is a general engine issue with practice mode that has only come up now (queued updates being generated from time 0 up to the practice section time) so I will handle this at a later point.

@RileyTheFox RileyTheFox mentioned this pull request Aug 2, 2024
Merged
@RileyTheFox RileyTheFox merged commit 1c8bb3b into YARC-Official:engine-refactor Aug 3, 2024
@Purplo-cf Purplo-cf deleted the countdown-rework branch August 4, 2024 02:23
Twiggy547 added a commit to Twiggy547/YARG that referenced this pull request Aug 12, 2024
@Twiggy547
Squashed commit of the following:
e256657 
commit f8bd97c
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Wed Aug 7 02:34:49 2024 +0100

    Fix errors after removing engine state classes

commit 0333c2f
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Mon Aug 5 16:12:22 2024 -0400

    Glissando note visuals

commit 8f0e088
Author: Nathan <nathanhurst03@gmail.com>
Date:   Mon Aug 5 05:50:34 2024 -0600

    Add setting for waiting on a song-specific video to seek in practice/replay

commit 2a8aa3a
Author: Nathan <nathanhurst03@gmail.com>
Date:   Mon Aug 5 05:45:49 2024 -0600

    Add log level setting to debug settings

commit 88081c6
Author: Nathan <nathanhurst03@gmail.com>
Date:   Mon Aug 5 04:07:24 2024 -0600

    Fix practice mode not waiting for video backgrounds to seek

commit b5792a4
Author: Nathan <nathanhurst03@gmail.com>
Date:   Mon Aug 5 03:43:14 2024 -0600

    Update pause start time when seeking the song
    Obsoletes `inputCompensation` and `OverridePauseTime`

commit 3c8bd48
Author: Nathan <nathanhurst03@gmail.com>
Date:   Mon Aug 5 03:23:32 2024 -0600

    Fix a couple typos in SongRunner

commit e398285
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Mon Aug 5 02:07:33 2024 +0100

    Pro Keys sustain visuals

commit 56f8d48
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sun Aug 4 22:15:14 2024 +0100

    Add inconsistent replay popup

commit 91b96ea
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Aug 3 21:43:24 2024 -0400

    Added missing translation key

commit 28e3288
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Aug 3 19:02:23 2024 -0400

    Reimplement proper `hasDescription` support for preset options

commit caf04ce
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Aug 3 16:43:21 2024 -0400

    Gameplay scene fixes

commit e18b6ef
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Aug 3 16:20:57 2024 -0400

    More merge fixes

commit 80482d7
Merge: 009a165 296557c
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Aug 3 16:11:03 2024 -0400

    Merge branch 'test' into engine-refactor

commit 296557c
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Aug 3 16:10:32 2024 -0400

    Merge fixes

commit 49280fc
Merge: c21b682 e0899b7
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Aug 3 14:17:34 2024 -0400

    Merge branch 'dev' into test

commit 009a165
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat Aug 3 17:35:47 2024 +0100

    i hate merging

commit e2cb425
Merge: b525ecf 1c8bb3b
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat Aug 3 17:33:47 2024 +0100

    forgor to pull countdown rework so merging now

commit b525ecf
Merge: c21b682 e0899b7
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat Aug 3 16:50:29 2024 +0100

    Merge remote-tracking branch 'upstream/dev' into engine-refactor

commit 1c8bb3b
Author: Purplo <33099317+Purplo-cf@users.noreply.github.com>
Date:   Sat Aug 3 07:28:28 2024 -0700

    Countdown rework (YARC-Official#825)

    * Removed "Get Ready" message

    * Added circular progress bar to countdowns

    * Fixed vocal countdown scaling. Optimized countdown change callback for sessions with multiple VocalPlayers

    * Update progress bar animation to reflect total wait time instead of total visible countdown time

    * Slight resize for vocals countdown

    * Replaced magic number with constant for fade out animation length

    * Rename variables for clarity

    * Fixed namespace for CountdownDisplay

    * Added support for configurable countdown display style. Measures, Seconds, Disabled

    * Adjusted progress bar size and vocals countdown position after latest engine-refactor changes

    * Rebuild corrupted unity files from engine-refactor

commit c21b682
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun Jul 28 23:57:48 2024 -0400

    Revert "Make sure countdown prefab uses RectTransforms instead of normal transforms and remove any scaling"

    This reverts commit 91829c4.

commit 91829c4
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jul 27 23:42:10 2024 -0400

    Make sure countdown prefab uses RectTransforms instead of normal transforms and remove any scaling

commit f3bba23
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jul 27 23:34:54 2024 -0400

    Seperate countdown elements into a new center elements container

commit 5d10443
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jul 27 23:26:20 2024 -0400

    Bring back key state changed event (it was removed for some reason)

commit 057270b
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jul 27 20:16:04 2024 -0400

    Removed using directive to make building work

commit 86d0bce
Author: Raphael Goulart <contact@raphaelgoul.art>
Date:   Sat Jul 20 13:31:59 2024 -0300

    Drum Hit SFX (YARC-Official#802)

    * Drum Hit SFX (with placeholder samples)

    * localize string + minor code fix

    * use regular hit anim for drum freestyle

    * revert unity L

    * update core

    * remove volume pre-mult (its on Core now)

    * Update YARG.Core

    * update new drum sounds v1 (wip)

    * update sample vol balance

    * update loc

    * git lfs track "*.opus"

    * only log drum sfx load failures

    * actually remove logging as its redundant

    * update private vars to _camelCase

    * fix faulty LogFormatError usage

    * remove unneeded check + add comments for clarity

commit bba4f8d
Author: Purplo <33099317+Purplo-cf@users.noreply.github.com>
Date:   Fri Jul 12 12:43:01 2024 -0700

    Wait countdown (YARC-Official#771)

    * Functional WaitCountdown prefab for Gameplay scene. Relies on wait-countdown-core branch in YARG.Core

    * Reverted whitespace formatting, whoops!

    * WaitCountdown prefab renamed to CountdownDisplay
    Countdown moved to the center of TrackViews

    * Changes from team feedback

    * Added fade in/out animation

    * Updates to YARG.Core

    * Missed a spot when rebasing

    * Countdown resize and Get Ready localization

    * Moved CountdownDisplay.cs file location

    * Moved to YARG.Localization

commit 19ff2a5
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Thu Jul 4 22:42:46 2024 -0400

    Merge fixes

commit 55dfe78
Merge: 073d496 23b8e48
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Thu Jul 4 22:22:07 2024 -0400

    Merge branch 'dev' into engine-refactor

commit 073d496
Merge: 2d06380 57e4608
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Thu Jun 20 02:10:09 2024 +0100

    Merge dev into engine-refactor

commit 2d06380
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Thu Jun 20 01:13:08 2024 +0100

    Use new StarPowerBarAmount and CanStarPowerActivate

commit f8dcb12
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Mon Jun 17 18:57:08 2024 -0400

    Made sustain line glowy if the color is dark enough

commit f6799e3
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jun 15 00:15:26 2024 -0400

    Fixed pro keys within rectangular theme prefab

commit 5a72d74
Author: Chris <33099317+Purplo-cf@users.noreply.github.com>
Date:   Fri Jun 14 12:41:22 2024 -0700

    Drum velocity (YARC-Official#794)

    * Velocity sensistivity for Drum controller inputs

    * On (no branch): Starting over

    * Added prefabs for Ghost/Accent notes

    * Fix YARG.Core submodule link

    * Reverted unintentional Unity changes

    * Renamed new accent/ghost models

    * Simplified isCymbal bool for FiveLaneDrumsNoteElement

    * //TODONE - Velocity support

    * Updates to YARG.Core

    * Updates to YARG.Core

    * Changes to YARG.Core

    * Updated YARG.Core

    * Updated YARG.Core

    * Updated YARG.Core

    * Material adjustments (still needs work)

    * Updated YARG.Core

    * Update Assets/Script/Input/Bindings/DrumPadButtonBinding.cs

    Co-authored-by: Nathan <nathanhurst03@gmail.com>

    * Updated submodule pointer to remote branch

    ---------

    Co-authored-by: Nathan <nathanhurst03@gmail.com>

commit af78e3e
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Tue Jun 4 22:44:44 2024 -0400

    Merged fixes

commit 1e6dbb9
Merge: a382d3c 065263e
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Tue Jun 4 22:28:05 2024 -0400

    Merge branch 'dev' into engine-refactor

commit a382d3c
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun Jun 2 16:36:54 2024 -0400

    Hide chord bar on chord hit

commit 32541a4
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun Jun 2 12:44:15 2024 -0400

    Made chord bars properly move with range shifts

commit 1a4637a
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jun 1 16:04:40 2024 -0400

    Added in chord bar ends

commit 05c2801
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jun 1 15:46:54 2024 -0400

    Reduced scale of measure beatlines to prevent visual conflicts with range shift indicators and chord bars

commit 42665b3
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Jun 1 15:41:07 2024 -0400

    Started chord bar implementation

commit 0bfcfaf
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat Jun 1 13:43:28 2024 +0100

    Fix unable to practice some sections on Pro Keys

    Resolves an index out of range error when trying to get the range shifts when setting the practice section.

commit baf1d41
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 31 17:35:09 2024 -0400

    Added pro keys score card

commit e35f1f5
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 31 17:25:20 2024 -0400

    Applied texture to range shifts

commit 0625954
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 29 21:36:30 2024 -0400

    Replace all `ChordEnumerator` usages

commit 708f27f
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Wed May 29 13:18:28 2024 +0100

    Get held key info from engine

commit 47c3a28
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Tue May 28 17:57:02 2024 -0400

    Fixed missing hit trigger

commit 09946c5
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Tue May 28 17:54:18 2024 -0400

    Adjusted noise on the black notes

commit 061b15b
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Tue May 28 17:52:07 2024 -0400

    Implemented pro keys note models

commit 19415c6
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue May 28 19:34:44 2024 +0100

    Add hard light blend and adjust highlight gradient

commit 8670a0f
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Mon May 27 20:37:33 2024 -0400

    Range shift indicators (no art yet)

commit acbb296
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Mon May 27 16:41:23 2024 -0400

    Hit particles

commit 8b1b4ef
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Mon May 27 16:20:46 2024 -0400

    Apply non-theme key array transformations to theme based models

commit 89ab7b4
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Mon May 27 16:16:46 2024 -0400

    Reimplement press effects for keys

commit e54936b
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Mon May 27 17:16:56 2024 +0100

    Hard-code 250ms range shift time

commit 9ce2839
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Mon May 27 17:16:44 2024 +0100

    Update YARG.Core for Fat Finger Window

commit fb48b15
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Mon May 27 00:02:24 2024 +0100

    thanks for not showing this error Rider

commit 4206edc
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sun May 26 23:13:06 2024 +0100

    Replace PianoHelper with YARG.Core ProKeysUtilities

commit 26c3a12
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun May 26 16:06:58 2024 -0400

    Apply proper colors to notes

commit 217eed1
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun May 26 14:14:22 2024 -0400

    Fix range shifts in practice

commit 4c38612
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sun May 26 18:58:13 2024 +0100

    Partial practice mode range shift fixes

commit fc39532
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun May 26 13:35:49 2024 -0400

    Removed old unused queries and move somethings around

commit 7cdf294
Author: poliwhirlge <141366895+poliwhirlge@users.noreply.github.com>
Date:   Sun May 26 13:18:25 2024 -0400

    Show best % score for instrument and difficulty of the highest score (YARC-Official#785)

    * Show best % score for instrument and difficulty of the highest score

    * Simplify + comment query, update any null Percent fields

commit 623f6f4
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat May 25 21:18:32 2024 -0400

    Utilize pro keys engine preset

commit 19583a0
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat May 25 23:39:57 2024 +0100

    OnOverhit function

commit fd67229
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat May 25 17:28:25 2024 -0400

    Stop using hardcoded values for preset settings and use attributes instead

commit 201e242
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat May 25 21:58:49 2024 +0100

    Subscribe to OnOverhit for Pro Keys

commit 67df195
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat May 25 01:03:54 2024 +0100

    Use new dynamic hit window variables in engine creation

commit 8b7e7cf
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 24 17:42:34 2024 -0400

    Update how black keys colors are fetched

commit 9a951e6
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 24 17:13:05 2024 -0400

    Key animations

commit 7af525d
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 24 20:49:12 2024 +0100

    Fix Pro Keys multiplayer object masking

commit a4da116
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 24 18:25:58 2024 +0100

    Move key overlay to beneath strikeline (not the highlight)

commit 2e551d9
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 24 14:16:57 2024 +0100

    Light up strikeline keys when pressed

commit 639b42e
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 24 13:56:28 2024 +0100

    Rotate keys when pressed

commit 05cfbd0
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 24 12:41:35 2024 +0100

    Stop key overlay going past strikeline

commit a05796a
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Thu May 23 19:23:33 2024 -0400

    Fixed incorrect front to back ratio number

commit 2e6c28b
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 22 21:38:02 2024 -0400

    Adjusted size of the keys

commit 1412831
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 22 21:20:40 2024 -0400

    Revert "Move strike line up for pro keys"

    This reverts commit b6c798e.

commit b6c798e
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 22 19:02:42 2024 -0400

    Move strike line up for pro keys

commit 7e01eba
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 22 18:44:03 2024 -0400

    Updated overlay textures

commit 05c442e
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 22 18:12:17 2024 -0400

    Spawn in highlights for white and black keys

commit f2c303c
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 22 17:45:12 2024 -0400

    Use texture scaling instead of keyword for texture flipping

commit f7f1175
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Wed May 22 21:44:34 2024 +0100

    Simplify shader

commit e3889d6
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Wed May 22 21:29:35 2024 +0100

    Got overlay edge glow working

commit 2567496
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Wed May 22 14:44:41 2024 +0100

    WIP overlay edge glow and alpha clip highlights if out of range

commit 90a82aa
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Wed May 22 00:05:10 2024 +0100

    Alpha mask strikeline keys

commit bf4ac11
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue May 21 23:11:03 2024 +0100

    Add color to black keys

commit a865f25
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue May 21 22:48:32 2024 +0100

    Remove branch from pro keys shader

commit 60aec22
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue May 21 21:39:37 2024 +0100

    Pro Keys highlights

commit 9ef4886
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue May 21 01:01:10 2024 +0100

    Make range shifts a struct and shift to first range shift at start of song

commit f4f89b8
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue May 21 00:15:22 2024 +0100

    Light up keys

commit 9fa8a4b
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun May 19 17:52:59 2024 -0400

    Move keys to the proper layer to prevent groove lighting from effecting them

commit 4d9aa2d
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun May 19 16:29:06 2024 -0400

    Get overlay colors from color profile

commit f6283da
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun May 19 12:58:59 2024 -0400

    Fixed track overlay being cutoff

commit 8985b37
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sun May 19 15:53:44 2024 +0100

    Basic track overlay for Pro Keys

commit e9767f5
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sun May 19 15:52:43 2024 +0100

    Organise some TrackElement scripts into subfolders

commit 946198d
Merge: 7c85c92 ec2ec54
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 17 23:37:22 2024 +0100

    Merge remote-tracking branch 'upstream/engine-refactor' into engine-refactor

commit 7c85c92
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 17 23:36:48 2024 +0100

    Uncomment Pro Keys bindings

commit 9d807fb
Merge: f658e65 40f2e8d
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri May 17 23:34:47 2024 +0100

    Merge dev into engine-refactor

commit ec2ec54
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 17 18:02:37 2024 -0400

    Basic pro-keys note hitting

commit b93ee9b
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 17 17:19:18 2024 -0400

    Display range shifts

commit f658e65
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed May 15 18:15:40 2024 -0400

    Pro keys range shifting

commit 195009e
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun May 12 14:50:42 2024 -0400

    Properly align notes with keys

commit 13dbdfa
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat May 11 17:56:41 2024 -0400

    Simplify theme container prefab further + keys array

commit cd7a430
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat May 11 16:22:08 2024 -0400

    Update YARG.Core

commit 01b7e35
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat May 11 00:28:06 2024 -0400

    Simplify theme container prefab storage

commit ee3be94
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 10 15:41:11 2024 -0400

    Added key prefabs to theme prefab

commit d6116c2
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri May 10 15:33:19 2024 -0400

    Added pro-keys player and key models

commit bba04e5
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat May 4 12:48:48 2024 -0400

    Uncommented pro-keys default bindings

commit 7b6aaac
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Mon Apr 29 17:45:18 2024 -0400

    Properly set `IsBot` values

commit 56cf17a
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun Apr 28 21:55:01 2024 -0400

    Align multiple percussion tracks properly

commit 9276c73
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Apr 27 22:48:43 2024 -0400

    Store percent in score database directly

commit 45d0ac0
Author: Sean Mansell <thearknano@gmail.com>
Date:   Fri Apr 26 05:01:42 2024 +0930

    [YARG-161] Add display for upcoming phrase in lyrics display (YARC-Official#745)

    * Functional simple next lyric display

    * Removed Strobe and Fog from Cue Change channel (YARC-Official#742)

    * Removed Strobe and Fog from Cue Change channel

    There are instances when a strobe or fog call will happen the same frame as a light cue, in that case the cue change channel will miss one of them. This change means the fog and strobe state should be read directly from their respective existing state channels.

    * Updated dmx cue channel setting description

    * typo fiix

    * Add time threshold to show upcoming lyrics

    * separate labels for 5-lane drum bindings (YARC-Official#744)

    * separate labels for 5-lane drum bindings

    5-lane drums bindings previously reused the 4-lane localization strings, meaning the numbers were weird and Orange Cymbal was just blank. giving 5L its own strings means we can label orange and uniquely number all five lanes.

    * rebranding 4L drum bind strings

    giving the four-lane drum pad/cymbal string ids a similar prefix as I'd given the five-lane ones.  also, consolidating both 4l/5l kicks into a single string, for potential reuse later

    * Add upcoming lyrics settings, modify display behaviour

    * extract upcoming lyrics codes to method and comment

    * Add upcoming lyrics loc strings

    ---------

    Co-authored-by: TheFatBastid <tfb@sof.ws>
    Co-authored-by: W Livi <wnivek@gmail.com>

commit f2c17cb
Merge: 7384e86 40620f3
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Thu Apr 25 15:30:20 2024 -0400

    Merge branch 'dev' into engine-refactor

commit 7384e86
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed Apr 24 17:49:38 2024 -0400

    Small particles adjustments

commit e66331c
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed Apr 24 17:47:59 2024 -0400

    Animation for vocal fret showing up

commit e299c4c
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed Apr 24 17:31:07 2024 -0400

    Added vocal fret and its particles

commit 5be693e
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Tue Apr 23 22:14:10 2024 -0400

    Hide vocal HUD in percussion phrases

commit b9a8b8f
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Tue Apr 23 18:19:09 2024 -0400

    Put in percussion note textures

commit 745abc3
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun Apr 21 21:50:10 2024 -0400

    Split up vocal percussion spawning into a per-player thing

commit 4c68670
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Apr 20 23:59:13 2024 -0400

    Allow MicDevice to transmit hit inputs

commit 1e2c128
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sat Apr 20 23:06:56 2024 -0400

    Change the `StarPower` vocal action to `Hit`

commit 1fc0887
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri Apr 19 18:23:54 2024 -0400

    Got vocal percussion spawning in

commit 59646d3
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed Apr 17 16:38:04 2024 -0400

    Updated YARG.Core and fixed merge whoopsie

commit 1cc2fbe
Merge: b58b8d1 aa6bace
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Wed Apr 17 16:12:38 2024 -0400

    Merge branch 'dev' into engine-refactor

commit b58b8d1
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Sun Apr 14 18:18:04 2024 -0400

    Change how singing and hitting is calculated to make it more accurately reflect the engine

commit a215ccf
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Fri Apr 12 22:12:37 2024 -0400

    Basic vocal engine rewrite

commit 06ab739
Author: EliteAsian <29520859+EliteAsian123@users.noreply.github.com>
Date:   Thu Apr 4 17:51:37 2024 -0400

    Update YARG.Core

commit a0e0837
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Wed Apr 3 21:59:23 2024 +0100

    bot change

commit 2ff2f5c
Merge: 4be8762 9de22b7
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue Mar 26 23:11:38 2024 +0000

    Merge upstream/dev to engine-refactor

commit 4be8762
Merge: d46cc0d e2fcb50
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat Mar 23 18:35:35 2024 +0000

    Merge remote-tracking branch 'upstream/dev' into engine-refactor

commit d46cc0d
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sat Mar 23 18:34:01 2024 +0000

    analysis logging change

commit f27000a
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Thu Mar 21 04:02:38 2024 +0000

    Change logging for replay analysis to YargLogger

commit 81b9049
Merge: 0762f61 b3193b1
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Tue Mar 19 14:40:39 2024 +0000

    Merge dev to engine-refactor

commit 0762f61
Merge: 97c83c3 cedac32
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Sun Mar 10 19:23:19 2024 +0000

    Merge remote-tracking branch 'upstream/dev' into engine-refactor

commit 97c83c3
Author: Nathan <nathanhurst03@gmail.com>
Date:   Sat Mar 9 00:39:24 2024 -0700

    Use new engine update API

commit e943dc5
Merge: 413ab2f e138519
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri Mar 8 20:43:23 2024 +0000

    Merge branch 'dev' into engine-refactor

commit 413ab2f
Merge: 245e050 bcbb67c
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Fri Mar 8 20:21:35 2024 +0000

    Merge branch `dev` into engine-refactor

commit 245e050
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Mon Feb 26 21:29:55 2024 +0000

    Clone notes in replay analyzer

commit b720dad
Author: RileyTheFox <jacobchambers@hotmail.co.uk>
Date:   Mon Feb 26 21:29:40 2024 +0000

    Add analyze button to history menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RileyTheFox RileyTheFox RileyTheFox approved these changes

Assignees
No one assigned
Labels
Requires YARG.Core PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Purplo-cf @RileyTheFox @EliteAsian123 @kaduwaengertner