Disable SP in practice #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RileyTheFox
requested changes
Aug 2, 2024
| @@ -495,6 +495,10 @@ | |||
| "Name": "Drums Volume", | |||
| "Description": "Adjusts the song's drum track volume. Only does something if the song is multi-track." | |||
| }, | |||
| "EnablePracticeSP": { | |||
| "Name": "Star Power in Practice", | |||
| "Description": "Allow Star Power phrases and activation while in Practice Mode." | |||
There was a problem hiding this comment.
Remove the text specifying it allows activations. These are not directly supported but are possible on drums only because of activation notes which is unintentional and a bug.
A practice mode that allows for activation and path practicing could be considered in the future but for now it is not supported and will be patched in the future.
Purplo-cf
force-pushed
the
disable-sp-in-practice
branch
from
7a2d1bb
to
d4d5db5
Compare
Purplo-cf
force-pushed
the
disable-sp-in-practice
branch
from
d4d5db5
to
a7a6cba
Compare
RileyTheFox
approved these changes
Aug 3, 2024
Purplo-cf
added a commit
to Purplo-cf/YARG
that referenced
this pull request
Aug 4, 2024
* Found an unrelated missing quote in the localization file * Setting to disable SP phrases in practice mode * Fixed display of Vocals lyric color when SP is disabled * Correct setting description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a setting to automatically strip star power from notes while in Practice mode. On by default.
Requires YARG.Core branch
disable-sp-coreto run