Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golden note edges for SP phrases #836

Closed

Conversation

Purplo-cf
Copy link
Contributor

@Purplo-cf Purplo-cf commented Jul 30, 2024

Change the color and material intensity of note metal for notes in Starpower phrases. Gold color by default to match the look of the RB series.

Allows for lightening the darker parts of the BaseMap texture while leaving the alpha channel alone
…tting of texture strength for each note in the theme prefab
@Purplo-cf Purplo-cf marked this pull request as ready for review July 30, 2024 11:01
@Purplo-cf
Copy link
Contributor Author

Purplo-cf commented Jul 31, 2024

After the discussion in the core PR, I have taken out all customization for the metal/gold color. Color is now being controlled by the static property SP_GOLD_COLOR in NoteRef. All changes are now contained in YARG without any core involvement.

@Purplo-cf Purplo-cf closed this Aug 4, 2024
@Purplo-cf Purplo-cf deleted the editable-note-metal branch August 4, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant