Fix lefty flip drum inputs #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RileyTheFox
pushed a commit
to RileyTheFox/YARG
that referenced
this pull request
Apr 15, 2023
* fixed lefty flip drum inputs * fixed bot drum lefty flip
EliteAsian123
added a commit
that referenced
this pull request
Apr 16, 2023
* Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * Add native bass library folders + READMEs for installation * IAudioManager interface and BASS implementation * Add ManagedBass to NuGet packages * Change Play and AbstractTrack to use new audio engine * Deleted old audio code and added StreamingAssets folder * Add gitignore to ignore BASS libraries * Adding generation of currentsong.text (#93) This is mainly for OBS to show on twitch streams. More stuff can be added but let's see if this works right first, ya? :) * Added reverb to player stems when star power is active * "ThirdParty" folder * Fix lefty flip on 4 and 5 lane drums (#96) * 4 lane drum lefty flip fix * 5 lane drum lefty flip fix * Updated credits * Add PlasticBand-Unity for input mappings, and HIDrogen for Linux HID support (#95) * Add PlasticBand-Unity package * Switch Pro Guitar support to PlasticBand's * Update input actions Guitar actions now use PlasticBand Removed most guitar UI actions, as they are covered by usages in PlasticBand * Add HIDrogen package for HID support on Linux * Fix lefty flip drum inputs (#99) * fixed lefty flip drum inputs * fixed bot drum lefty flip * Re-enable incremental garbage collection (#101) * Improve HO/PO overstrum forgiveness (#100) * Allow anchoring chord HO/POs (togglable) * Improve HO/PO overstrum forgiveness * Small fix * Add clap and starpower deploy sfx * Add clap sfx to code * Reverb keys stems and all drums stems * Stem gain on SP and volume control settings * Update and add new starpower SFX * meta file update? * Weird curly brace problem and 2 update checkers? Whats happening --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art>
EliteAsian123
added a commit
that referenced
this pull request
Apr 16, 2023
* Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * Add native bass library folders + READMEs for installation * IAudioManager interface and BASS implementation * Add ManagedBass to NuGet packages * Change Play and AbstractTrack to use new audio engine * Deleted old audio code and added StreamingAssets folder * Add gitignore to ignore BASS libraries * Adding generation of currentsong.text (#93) This is mainly for OBS to show on twitch streams. More stuff can be added but let's see if this works right first, ya? :) * Added reverb to player stems when star power is active * "ThirdParty" folder * Fix lefty flip on 4 and 5 lane drums (#96) * 4 lane drum lefty flip fix * 5 lane drum lefty flip fix * Updated credits * Add PlasticBand-Unity for input mappings, and HIDrogen for Linux HID support (#95) * Add PlasticBand-Unity package * Switch Pro Guitar support to PlasticBand's * Update input actions Guitar actions now use PlasticBand Removed most guitar UI actions, as they are covered by usages in PlasticBand * Add HIDrogen package for HID support on Linux * Fix lefty flip drum inputs (#99) * fixed lefty flip drum inputs * fixed bot drum lefty flip * Re-enable incremental garbage collection (#101) * Improve HO/PO overstrum forgiveness (#100) * Allow anchoring chord HO/POs (togglable) * Improve HO/PO overstrum forgiveness * Small fix * Add clap and starpower deploy sfx * Add clap sfx to code * Reverb keys stems and all drums stems * Stem gain on SP and volume control settings * Update and add new starpower SFX * meta file update? * Weird curly brace problem and 2 update checkers? Whats happening * Add note miss sfx * Add sfx volume and use star power fx controls. Play note miss on combo >= 10 --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art>
EliteAsian123
added a commit
that referenced
this pull request
Apr 16, 2023
* initial work on score mechanics * initial work on score mechanics * add tempo keeping, sustain score adding with tempo * fix styling, sustain-tempo math * fix line endings * add condition to prevent out of bounds crash in updating curBeatPerSecond * implement MaxSustainScore method to be used in capping achievable sustain points * fix MaxSustainPoints logic * refactoring ScoreKeeper instance management * try to make sustain scoring deterministic * add Score_Box graphic; fix sustain scoring for if the note goes beyond beat markers * refactoring * add conventional BPM Play.tempo property * Move some Utils methods to more relevant locations, and other misc. changes (#79) * Move VolumeFromLinear from Utils to AudioManager * Move SplitNoteToOctaveAndNote from Utils to LyricInfo * Turn RectTransform utility methods into extension methods * Move Hash from Utils to SongLibrary * Use const case for sources URL constant name * Unity keeps modifying this so w/e * Add strum leniency to five fret guitar (#83) * Ignore .idea folder * Strum leniency added to FiveFretTrack * Adjusted strum leniency to 65ms * Comment fixes * Update README.md * Added some sources * Allow anchoring chord HO/POs (togglable) (#85) * Removed Patreon from Main Menu * Added credits * Add song length to Play.cs for song end (#86) * Fix bot overstrumming (#87) * Small comment for later * Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * move sustain tracking to separate file, other sus refactoring * add scoring for drums * add BarlowBold reference for scorebox * Adding generation of currentsong.text (#93) This is mainly for OBS to show on twitch streams. More stuff can be added but let's see if this works right first, ya? :) * "ThirdParty" folder * Fix lefty flip on 4 and 5 lane drums (#96) * 4 lane drum lefty flip fix * 5 lane drum lefty flip fix * Updated credits * Add PlasticBand-Unity for input mappings, and HIDrogen for Linux HID support (#95) * Add PlasticBand-Unity package * Switch Pro Guitar support to PlasticBand's * Update input actions Guitar actions now use PlasticBand Removed most guitar UI actions, as they are covered by usages in PlasticBand * Add HIDrogen package for HID support on Linux * implement scoring for all, move ScoreKeeper initialization, refactor * Fix lefty flip drum inputs (#99) * fixed lefty flip drum inputs * fixed bot drum lefty flip * Re-enable incremental garbage collection (#101) * Improve HO/PO overstrum forgiveness (#100) * Allow anchoring chord HO/POs (togglable) * Improve HO/PO overstrum forgiveness * Small fix * swap for adjusted score box sprite * implement StarKeeper and set up with player tracks (sans vocals) * add StarDisplay for Play UI * add vocals and harmVocals star thresholds * fix play scorebox graphic import * add StarDisplay, refactor score display is now its own class, now only updates on event (score add) --------- Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: RileyTheFox <jacobchambers@hotmail.co.uk> Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com>
EliteAsian123
added a commit
that referenced
this pull request
Apr 16, 2023
* Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * Add native bass library folders + READMEs for installation * IAudioManager interface and BASS implementation * Add ManagedBass to NuGet packages * Change Play and AbstractTrack to use new audio engine * Deleted old audio code and added StreamingAssets folder * Add gitignore to ignore BASS libraries * Adding generation of currentsong.text (#93) This is mainly for OBS to show on twitch streams. More stuff can be added but let's see if this works right first, ya? :) * Added reverb to player stems when star power is active * "ThirdParty" folder * Fix lefty flip on 4 and 5 lane drums (#96) * 4 lane drum lefty flip fix * 5 lane drum lefty flip fix * Updated credits * Add PlasticBand-Unity for input mappings, and HIDrogen for Linux HID support (#95) * Add PlasticBand-Unity package * Switch Pro Guitar support to PlasticBand's * Update input actions Guitar actions now use PlasticBand Removed most guitar UI actions, as they are covered by usages in PlasticBand * Add HIDrogen package for HID support on Linux * Fix lefty flip drum inputs (#99) * fixed lefty flip drum inputs * fixed bot drum lefty flip * Re-enable incremental garbage collection (#101) * Improve HO/PO overstrum forgiveness (#100) * Allow anchoring chord HO/POs (togglable) * Improve HO/PO overstrum forgiveness * Small fix * Add clap and starpower deploy sfx * Add clap sfx to code * Reverb keys stems and all drums stems * Stem gain on SP and volume control settings * Update and add new starpower SFX * meta file update? * Weird curly brace problem and 2 update checkers? Whats happening * Add note miss sfx * Add sfx volume and use star power fx controls. Play note miss on combo >= 10 --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art>
EliteAsian123
added a commit
that referenced
this pull request
Apr 17, 2023
* Implement new audio engine (#94) * Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * Add native bass library folders + READMEs for installation * IAudioManager interface and BASS implementation * Add ManagedBass to NuGet packages * Change Play and AbstractTrack to use new audio engine * Deleted old audio code and added StreamingAssets folder * Add gitignore to ignore BASS libraries * Added reverb to player stems when star power is active --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> * Added Starpower SFX to Audio Engine (#102) * Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * Add native bass library folders + READMEs for installation * IAudioManager interface and BASS implementation * Add ManagedBass to NuGet packages * Change Play and AbstractTrack to use new audio engine * Deleted old audio code and added StreamingAssets folder * Add gitignore to ignore BASS libraries * Adding generation of currentsong.text (#93) This is mainly for OBS to show on twitch streams. More stuff can be added but let's see if this works right first, ya? :) * Added reverb to player stems when star power is active * "ThirdParty" folder * Fix lefty flip on 4 and 5 lane drums (#96) * 4 lane drum lefty flip fix * 5 lane drum lefty flip fix * Updated credits * Add PlasticBand-Unity for input mappings, and HIDrogen for Linux HID support (#95) * Add PlasticBand-Unity package * Switch Pro Guitar support to PlasticBand's * Update input actions Guitar actions now use PlasticBand Removed most guitar UI actions, as they are covered by usages in PlasticBand * Add HIDrogen package for HID support on Linux * Fix lefty flip drum inputs (#99) * fixed lefty flip drum inputs * fixed bot drum lefty flip * Re-enable incremental garbage collection (#101) * Improve HO/PO overstrum forgiveness (#100) * Allow anchoring chord HO/POs (togglable) * Improve HO/PO overstrum forgiveness * Small fix * Add clap and starpower deploy sfx * Add clap sfx to code * Reverb keys stems and all drums stems * Stem gain on SP and volume control settings * Update and add new starpower SFX * meta file update? * Weird curly brace problem and 2 update checkers? Whats happening --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> * Add SFX Volume and Star Power FX Controls to new audio engine (#106) * Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * Add native bass library folders + READMEs for installation * IAudioManager interface and BASS implementation * Add ManagedBass to NuGet packages * Change Play and AbstractTrack to use new audio engine * Deleted old audio code and added StreamingAssets folder * Add gitignore to ignore BASS libraries * Adding generation of currentsong.text (#93) This is mainly for OBS to show on twitch streams. More stuff can be added but let's see if this works right first, ya? :) * Added reverb to player stems when star power is active * "ThirdParty" folder * Fix lefty flip on 4 and 5 lane drums (#96) * 4 lane drum lefty flip fix * 5 lane drum lefty flip fix * Updated credits * Add PlasticBand-Unity for input mappings, and HIDrogen for Linux HID support (#95) * Add PlasticBand-Unity package * Switch Pro Guitar support to PlasticBand's * Update input actions Guitar actions now use PlasticBand Removed most guitar UI actions, as they are covered by usages in PlasticBand * Add HIDrogen package for HID support on Linux * Fix lefty flip drum inputs (#99) * fixed lefty flip drum inputs * fixed bot drum lefty flip * Re-enable incremental garbage collection (#101) * Improve HO/PO overstrum forgiveness (#100) * Allow anchoring chord HO/POs (togglable) * Improve HO/PO overstrum forgiveness * Small fix * Add clap and starpower deploy sfx * Add clap sfx to code * Reverb keys stems and all drums stems * Stem gain on SP and volume control settings * Update and add new starpower SFX * meta file update? * Weird curly brace problem and 2 update checkers? Whats happening * Add note miss sfx * Add sfx volume and use star power fx controls. Play note miss on combo >= 10 --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> * Moved BASS to libraries, and added install script * Final touches to audio engine (#108) * Add update check on startup (#91) * Created update checker, runs on startup * Add current version and update notification to main menu * Update version back to 0.8.2 * Moved engine constants to `Constants` * Awesomeness Detection (#89) * Awesomeness detection EXTREMLY IMPORTANT * Awesomeness Detection Very important! * Pretty awesome if you ask me * Add native bass library folders + READMEs for installation * IAudioManager interface and BASS implementation * Add ManagedBass to NuGet packages * Change Play and AbstractTrack to use new audio engine * Deleted old audio code and added StreamingAssets folder * Add gitignore to ignore BASS libraries * Adding generation of currentsong.text (#93) This is mainly for OBS to show on twitch streams. More stuff can be added but let's see if this works right first, ya? :) * Added reverb to player stems when star power is active * "ThirdParty" folder * Fix lefty flip on 4 and 5 lane drums (#96) * 4 lane drum lefty flip fix * 5 lane drum lefty flip fix * Updated credits * Add PlasticBand-Unity for input mappings, and HIDrogen for Linux HID support (#95) * Add PlasticBand-Unity package * Switch Pro Guitar support to PlasticBand's * Update input actions Guitar actions now use PlasticBand Removed most guitar UI actions, as they are covered by usages in PlasticBand * Add HIDrogen package for HID support on Linux * Fix lefty flip drum inputs (#99) * fixed lefty flip drum inputs * fixed bot drum lefty flip * Re-enable incremental garbage collection (#101) * Improve HO/PO overstrum forgiveness (#100) * Allow anchoring chord HO/POs (togglable) * Improve HO/PO overstrum forgiveness * Small fix * Add clap and starpower deploy sfx * Add clap sfx to code * Reverb keys stems and all drums stems * Stem gain on SP and volume control settings * Update and add new starpower SFX * meta file update? * Weird curly brace problem and 2 update checkers? Whats happening * Add note miss sfx * Add sfx volume and use star power fx controls. Play note miss on combo >= 10 --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art> * Readme update * Unity moment * Fixed merge issues * Fixed formatting * Small changes * Fixed songs not loading * Removed debug log --------- Co-authored-by: EliteAsian <lavasnakegaming@gmail.com> Co-authored-by: TheFatBastid <tfb@sof.ws> Co-authored-by: Rodrigo Oliveira <39157156+santorfo@users.noreply.github.com> Co-authored-by: Nathan <nathanhurst03@gmail.com> Co-authored-by: Raphael Goulart <contact@raphaelgoul.art>
Purplo-cf
pushed a commit
to Purplo-cf/YARG
that referenced
this pull request
May 14, 2024
+ prefills the phrase tracking dictionary with the valid types to make TryGetValue-like calls redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96 did not fix the inputs, only the note colors, as DarkRTA mentioned.
I've now flipped the inputs when they're being processed as a hit, except when bot mode is on.
Fixes #56 for real this time.