-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
教育資料のフィードバックの機能の実装 #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the Feedback model from the schema.prisma file to align with the updated data structure.
Removed unnecessary error message in catch block.
- changed the metadata decorator from ApiAuthMetadata to ApiDefaultMetadata - change method's name from delete to remove
…piDefaultMetadata
- Added new constants NO_IDEA and NO_IDEA_MESSAGE for handling unknown answers - Updated answer logic to display NO_IDEA_MESSAGE when answer is unknown - Improved referInfo formatting in the answer - Updated comments for better clarity
Prevents potential errors when referInfo is empty
…of receiving feedback YJU-OKURA#50
Z00One
added
🔨 Refactor
코드 리팩토링
📬 API
서버 API 통신
⏰ P1
반드시 해결해야 하는 중요한 이슈나 문제 (예: 버그, 취약점 등)
🆗 safe
CI workflow 동작 관련
labels
Mar 19, 2024
prisma/migrations/20240311104326_add_created_at_column_in_refer_table/migration.sql
Show resolved
Hide resolved
yuminn-k
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~ :)
P3: 한 개의 PR에 업데이트되는 로직의 양이 많아서 조금씩 나눠서 PR해도 괜찮을 것 같습니다. 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📬 API
서버 API 통신
✨ Feature
기능 개발
⏰ P1
반드시 해결해야 하는 중요한 이슈나 문제 (예: 버그, 취약점 등)
🔨 Refactor
코드 리팩토링
✅ Test
test 관련(storybook, jest...)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 このPRで解決したい問題は何ですか?
✨ このPRで主に変わったことは何ですか?
File
モジュール構成Materialfeedback
モジュール、Langchain
モジュール)🔖 主な変更点以外に追加で変更された部分はありますか?
refer
モジュールのディレクトリの経路変更material
モジュールで資料の削除のメソッドの名前変更(delete
->remove
)🙏🏻 Reviewerに特に見ていただきたい部分はありますか?
🩺 このPRでテストや検証が必要な部分はありますか?
📚 関連するIssueやTrello、ドキュメント
🖥 作動する様子
📌 PRを行う際の注意点