-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
プロンプトのリスポンスをストリーミングするように修正 #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add response object to langchain service methods to handle HTTP responses in the service. Update method signatures and implementations to include the response object. Also, added caution message in the createChain method to handle unknown answers appropriately. YJU-OKURA#54
Add response parameter to the question method in the PromptService to handle Express response objects. YJU-OKURA#54
- Added pagination function to `get` method: modified to receive and process `page` and `limit` query parameters. - Added asynchronous processing to the `question` method and modified it to handle the `Response` object directly. After executing the method, explicitly end the response with `response.end()`. YJU-OKURA#54
Z00One
added
✅ Test
test 관련(storybook, jest...)
🔨 Refactor
코드 리팩토링
🐞 BugFix
Something isn't working
⏰ P2
활발하게 고려해야 하는 이슈나 개선사항
🆗 safe
CI workflow 동작 관련
labels
Mar 21, 2024
yuminn-k
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 BugFix
Something isn't working
⏰ P2
활발하게 고려해야 하는 이슈나 개선사항
🔨 Refactor
코드 리팩토링
🆗 safe
CI workflow 동작 관련
✅ Test
test 관련(storybook, jest...)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 このPRで解決したい問題は何ですか?
✨ このPRで主に変わったことは何ですか?
🔖 主な変更点以外に追加で変更された部分はありますか?
🙏🏻 Reviewerに特に見ていただきたい部分はありますか?
🩺 このPRでテストや検証が必要な部分はありますか?
📚 関連するIssueやTrello、ドキュメント
🖥 作動する様子
📌 PRを行う際の注意点