-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
クイズCRUDの実装 #61
Merged
Merged
クイズCRUDの実装 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added metadata decorator for use-owner-guards to handle model and id parameters
-Added metadata decorator to use in place of Roles decorator for role guards
- Added metadata decorator for owner guard to handle dynamic model and id param name - Updated canActivatePrompt method to check ownership based on dynamic model and id param name - Updated error messages for better clarity and consistency
- Updated the import statement in role.guard.ts file to use the correct Key constant from metadata.decorator instead of the outdated KEY_OF_ROLES constant.
Added QuizList model to the Prisma schema to handle the relationship between quizzes and sets of quizzes. This will improve the organization of data related to quizzes and sets. YJU-OKURA#60
Z00One
added
✨ Feature
기능 개발
🔨 Refactor
코드 리팩토링
📬 API
서버 API 통신
⏰ P1
반드시 해결해야 하는 중요한 이슈나 문제 (예: 버그, 취약점 등)
🆗 safe
CI workflow 동작 관련
labels
Apr 4, 2024
yuminn-k
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~ :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📬 API
서버 API 통신
✨ Feature
기능 개발
⏰ P1
반드시 해결해야 하는 중요한 이슈나 문제 (예: 버그, 취약점 등)
🔨 Refactor
코드 리팩토링
🆗 safe
CI workflow 동작 관련
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 このPRで解決したい問題は何ですか?
✨ このPRで主に変わったことは何ですか?
🔖 主な変更点以外に追加で変更された部分はありますか?
🙏🏻 Reviewerに特に見ていただきたい部分はありますか?
🩺 このPRでテストや検証が必要な部分はありますか?
📚 関連するIssueやTrello、ドキュメント
🖥 作動する様子
📌 PRを行う際の注意点