-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
クイズバンクAPIの修正 #73
Merged
Merged
クイズバンクAPIの修正 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed c_id parameter from findMany method - Updated where condition to only use u_id - Removed class_user object from where condition - Updated search method to remove c_id parameter from where condition - Updated create method to remove c_id parameter - Added getQuiz method to retrieve quiz content based on id and c_id
- Updated create method in QuizBankService to fetch quiz content from repository before creating - Added error handling to check if quiz is not found before creating - Improved code readability and error handling in create method - Removed unnecessary parameter from create method - Updated method signature to match new requirements - Updated method logic to handle quiz content retrieval before creating
… and URI conventions
- Refactored error handling logic in quiz-bank controller methods - Removed unnecessary parameter checks for c_id in search and getMany methods
Add ApiParam to the UseRoleGuards decorator in order to include 'c_id' parameter when required.
- Updated the controller routes to include 'api/nest/' prefix for better organization and clarity - Removed redundant Role.ADMIN guards from controller methods
Updated the global prefix in the main.ts file to exclude 'api/nest/quiz-banks/:id' endpoint from the prefix
Z00One
added
🔨 Refactor
코드 리팩토링
📬 API
서버 API 통신
⏰ P2
활발하게 고려해야 하는 이슈나 개선사항
🆗 safe
CI workflow 동작 관련
labels
May 3, 2024
prisma/migrations/20240503013001_drop_columns_of_quizbank_table/migration.sql
Show resolved
Hide resolved
yuminn-k
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 このPRで解決したい問題は何ですか?
✨ このPRで主に変わったことは何ですか?
🔖 主な変更点以外に追加で変更された部分はありますか?
🙏🏻 Reviewerに特に見ていただきたい部分はありますか?
🩺 このPRでテストや検証が必要な部分はありますか?
📚 関連するIssueやTrello、ドキュメント
🖥 作動する様子
📌 PRを行う際の注意点