Skip to content

Commit

Permalink
Fix remove amazon for 2304
Browse files Browse the repository at this point in the history 
This is "system_as_root", while /apex is automatically mounted during boot.
  • Loading branch information
@s1204IT
s1204IT authored May 14, 2023
1 parent 595afd7 commit d0a80e8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/build.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ if [ "$REMOVE_AMAZON" ]; then
echo "Remove Amazon Appstore"
find "${PRODUCT_MNT:?}"/{etc/permissions,etc/sysconfig,framework,priv-app} 2>/dev/null | grep -e amazon -e venezia | sudo xargs rm -rf
find "${SYSTEM_EXT_MNT:?}"/{etc/*permissions,framework,priv-app} 2>/dev/null | grep -e amazon -e venezia | sudo xargs rm -rf
sudo rm -rf "${ROOT_MNT}"/apex/com.microsoft.mado*
rm -rf "$WORK_DIR/wsa/$ARCH/apex"
echo -e "done\n"
fi

Expand Down

5 comments on commit d0a80e8

@s1204IT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YT-Advanced
I have a suggestion, why don't we remove OpenGApps from the GApps flavor?
It no longer deserves to exist.

@MustardChef
Copy link

@MustardChef MustardChef commented on d0a80e8 May 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YT-Advanced Just want to let you know that WSAPatch is now broken in WSA v2304 and higher version. You should disable installation on Windows 10 in the meantime

@s1204IT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YT-Advanced Just want to let you know that WSAPatch is now broken in WSA v2304 and higher version. You should disable installation on Windows 10 in the meantime

If the correction is not made when v2304 becomes the Retail version, we will consider removing it.

@MustardChef
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YT-Advanced Just want to let you know that WSAPatch is now broken in WSA v2304 and higher version. You should disable installation on Windows 10 in the meantime

If the correction is not made when v2304 becomes the Retail version, we will consider removing it.

I have opened an issue here: cinit/WSAPatch#33

@YT-Advanced
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YT-Advanced I have a suggestion, why don't we remove OpenGApps from the GApps flavor? It no longer deserves to exist.

Hmm, I know but somebody continue use it

Please sign in to comment.