Add 'BXT_DISABLE_DISCORD_RPC' environment variable #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Feb 17, 2023
YaLTeR
reviewed
Feb 17, 2023
SmileyAG
force-pushed
the
disable_discord_rpc
branch
from
dadc0ca
to
eb7d099
Compare
|
getenv is doing a look-up by string, which is costly and not something we want to do every frame. Please change it so discord integration checks getenv once upon initialization, after which it sets an internal flag (whether it's enabled or not), and then the discord integration functions themselves check that flag (so no extra checks in the hooks). |
SmileyAG
force-pushed
the
disable_discord_rpc
branch
from
eb7d099
to
e116899
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.