Replace derive_more with thiserror
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
Commit d9829cc ("Remove failure dependency") made the case that `thiserror` could be used as a replacement for the `failure` crate just as well, but opted to use `derive_more` as it was "already used" by `wl-clipboard-rs`. Checking the repo before that commit reveals that this was an unused dependency lingering in `Cargo.toml`, without any other references to `derive_more`. Furthermore `derive_more` is an extremely heavy crate that is causing a multitude of issues for us ([such as inordinate compile times]) which is why we deter it from our dependency graph altogether. [such as inordinate compile times]: gfx-rs/rspirv#218 (comment)
MarijnS95
force-pushed
the
thiserror
branch
from
d79a25d
to
49aae57
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d9829cc ("Remove failure dependency") made the case that
thiserrorcould be used as a replacement for thefailurecrate just as well, but opted to usederive_moreas it was "already used" bywl-clipboard-rs. Checking the repo before that commit reveals that this was an unused dependency lingering inCargo.toml, without any other references toderive_more.Furthermore
derive_moreis an extremely heavy crate that is causing a multitude of issues for us (such as inordinate compile times) which is why we deter it from our dependency graph altogether.