use current title/url as default for pushState/replaceState #88

lingyan · 2015-03-30T18:51:24Z

@mridgway @redonkulus cc: @gpbl
Fixes #86

yahoocla · 2015-03-30T18:51:25Z

CLA is valid!

mridgway · 2015-03-30T18:53:44Z

👍

coveralls · 2015-03-30T18:55:17Z

Coverage remained the same at 99.62% when pulling 7a5b1d2 on undefinedURL into 6a3e90c on master.

coveralls · 2015-03-30T18:55:22Z

Coverage remained the same at 99.62% when pulling 7a5b1d2 on undefinedURL into 6a3e90c on master.

coveralls · 2015-03-30T18:55:23Z

Coverage remained the same at 99.62% when pulling 7a5b1d2 on undefinedURL into 6a3e90c on master.

coveralls · 2015-03-30T19:03:20Z

Coverage remained the same at 99.62% when pulling 3041d84 on undefinedURL into 6a3e90c on master.

coveralls · 2015-03-30T19:03:20Z

Coverage remained the same at 99.62% when pulling 3041d84 on undefinedURL into 6a3e90c on master.

coveralls · 2015-03-30T19:03:21Z

Coverage remained the same at 99.62% when pulling 3041d84 on undefinedURL into 6a3e90c on master.

use current title/url as default for pushState/replaceState

gpbl · 2015-03-30T20:01:54Z

awesome, thank you!

lingyan added the in progress label Mar 30, 2015

use current title/url as default for pushState/replaceState

3041d84

lingyan force-pushed the undefinedURL branch from 7a5b1d2 to 3041d84 Compare March 30, 2015 18:59

lingyan added a commit that referenced this pull request Mar 30, 2015

Merge pull request #88 from yahoo/undefinedURL

7d05353

use current title/url as default for pushState/replaceState

lingyan merged commit 7d05353 into master Mar 30, 2015

lingyan removed the in progress label Mar 30, 2015

lingyan deleted the undefinedURL branch March 30, 2015 19:13

lingyan mentioned this pull request Apr 21, 2015

On Internet Explorer, RouterMixin's "Scroll Position Management" is setting the url path to "undefined" #93

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use current title/url as default for pushState/replaceState #88

use current title/url as default for pushState/replaceState #88

lingyan commented Mar 30, 2015

yahoocla commented Mar 30, 2015

mridgway commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

gpbl commented Mar 30, 2015

use current title/url as default for pushState/replaceState #88

use current title/url as default for pushState/replaceState #88

Conversation

lingyan commented Mar 30, 2015

yahoocla commented Mar 30, 2015

mridgway commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

coveralls commented Mar 30, 2015

gpbl commented Mar 30, 2015