Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme-2.19.0 #778

Merged
merged 11 commits into from
Nov 26, 2024
Merged

readme-2.19.0 #778

merged 11 commits into from
Nov 26, 2024

Conversation

YamatoSecurity
Copy link
Collaborator

@YamatoSecurity YamatoSecurity commented Nov 25, 2024

@fukusuket Could you check this over and could I ask you to do update the Japanese translations?

Also closes #754

@YamatoSecurity YamatoSecurity added the documentation Improvements or additions to documentation label Nov 25, 2024
@YamatoSecurity YamatoSecurity self-assigned this Nov 25, 2024
@YamatoSecurity
Copy link
Collaborator Author

@fukusuket I forgot to mention, could you also update support-modifier.py to support the new modifiers (lt, etc..)?

I noticed that fieldref|startswith and fieldref|contains are not listed in the supported field modifiers, so can you add these?

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀 I updated Japanese README and supported-modifier.py!

@fukusuket
Copy link
Collaborator

I noticed that fieldref|startswith and fieldref|contains are not listed in the supported field modifiers, so can you add these?

I updated!!💪

@YamatoSecurity
Copy link
Collaborator Author

Thanks so much for the update!
One more thing, could you also add the following to the supported modifiers: startswith|cased, endswith|cased, contains|cased

I think we should document because I forgot how cased gets used. 😄

@YamatoSecurity
Copy link
Collaborator Author

I added the cased variations to the readme. Could you update the JP translation one more time?

@fukusuket
Copy link
Collaborator

Yes, I updated it!!💪

Signed-off-by: Zach Mathis (田中ザック) <71482215+YamatoSecurity@users.noreply.github.com>
@YamatoSecurity YamatoSecurity merged commit 3de77e8 into main Nov 26, 2024
2 checks passed
@YamatoSecurity YamatoSecurity deleted the readme-2.19.0 branch November 26, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rules to use fieldref instead of equalsfield, etc... [mid-late November]
2 participants