Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration-test for takajo command #102

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

fukusuket
Copy link
Collaborator

What Changed

Test

I have confirmed that the repository in my account works correctly as shown below.
https://github.com/fukusuket/takajo-fukusuket/actions/runs/7860706970/job/21448190160

Also, while creating the test, I found a bug in the split-csv-timeline command as follows, so I will create an issue.
https://github.com/fukusuket/takajo-fukusuket/actions/runs/7860549962/job/21447839645

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket added the enhancement New feature or request label Feb 11, 2024
@fukusuket fukusuket added this to the v2.4.0 milestone Feb 11, 2024
@fukusuket fukusuket self-assigned this Feb 11, 2024
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket Thanks so much for this. Indeed, we should start making tests to make sure that nothing breaks.

Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YamatoSecurity YamatoSecurity merged commit 176a22e into main Feb 13, 2024
2 checks passed
@fukusuket fukusuket deleted the add-actions-for-integration-test branch February 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants