-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show alert level for stacking command #113
Conversation
refactor: move terminal related func to takajoTerminal.nim
@fukusuket Thanks so much! Sorry, I don't think my explanation was good. I want to combine all of these into one big table. So the columns would be |
@YamatoSecurity Also, depending on the command,
what do you think? |
@fukusuket Thanks for adding the |
@YamatoSecurity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket Looks great! Thanks so much. I changed the ,
separator to |
to make it easier to read and added some messages about what log events are being used. If my commits look ok, please merge this.
@YamatoSecurity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Changed
Standard output specifications
I tried creating it with the above specifications, but what do you think? Please let me know if there is anything that should be changed :)
Test
In the integration test below, I confirmed that the altert level is output to stdout.
I would appreciate it if you could check it out when you have time🙏