-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stack-users/stack-ip-addresses #131
Conversation
refactor: remove duplicated jsonl process code
stack-users
|
stack-ip-addresses
|
help
|
refactor: remove duplicated jsonl process code
@fukusuket Sorry, I didn't realize you updated |
@fukusuket Maybe rename |
@YamatoSecurity |
@fukusuket Thanks so much! Sorry about that.
(there are probably more) What about an option --filterSystemAccounts (default: true) that will filter out the above accounts? Also, I noticed that computer accounts (the ones that end with |
@YamatoSecurity Thank you so much for checking :) I implemented filter out |
@fukusuket I think that's a good idea! |
@YamatoSecurity |
Thanks so much! I just noticed that when analyzing source users, |
@YamatoSecurity Thank you so much for checking! I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket Thanks so much. LGTM! I just updated the messages to explain what fields we are analyzing.
What Changed
stack-users
command #130stack-ip-addresses
command #129processJSONL
Test
Environment
In the integration test below, I confirmed that the all commands succeeded.
I would appreciate it if you could check it out when you have time🙏