Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply Template method pattern for automagic command #135

Merged
merged 34 commits into from
Mar 14, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Mar 13, 2024

What Changed

New Feature

Refactoring

Integration-Test

I confirmed that the integration test is successful as shown below.
https://github.com/Yamato-Security/takajo/actions/runs/8267602168
also I confirmed that the progress bar is not displayed when the -s option is added.

Test

Environment

  • OS: macOS Sonoma version 14.2.1
  • Hayabusa v2.14.0-dev
  • Nim: 2.0.2
  • nimble: 0.14.2

Sorry for the PR with a lot of commits...
I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket changed the title refactor: apply template method pattern for automagic command refactor: apply Template method pattern for automagic command Mar 13, 2024
@fukusuket fukusuket added this to the v2.5.0 milestone Mar 13, 2024
@fukusuket fukusuket added the enhancement New feature or request label Mar 13, 2024
@fukusuket fukusuket self-assigned this Mar 13, 2024
@fukusuket fukusuket marked this pull request as ready for review March 13, 2024 10:42
@fukusuket fukusuket mentioned this pull request Mar 13, 2024
@fukusuket
Copy link
Collaborator Author

Test

Environment

  • OS: Windows11
  • Hayabusa v2.14.0-dev
  • Nim: 2.0.2
  • nimble: 0.14.2

I also confirmed that there are no differences by comparing the following command with v2.4.0 on Windows.

PS C:\tmp\takajo-2.4.0-win\result> dir


    ディレクトリ: C:\tmp\takajo-2.4.0-win\result


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d-----        2024/03/14      7:13                scriptblock-logs-new
d-----        2024/03/14      7:13                scriptblock-logs-old
-a----        2024/03/14      7:13          20340 extract-script-summary-new.csv
-a----        2024/03/14      7:13          20340 extract-script-summary-old.csv
-a----        2024/03/14      7:15             16 list-domains-new.txt
-a----        2024/03/14      7:14             16 list-domains-old.txt
-a----        2024/03/14      7:15           3026 list-hash-new-ImportHashes.txt
-a----        2024/03/14      7:15           3264 list-hash-new-MD5-hashes.txt
-a----        2024/03/14      7:15           3864 list-hash-new-SHA1-hashes.txt
-a----        2024/03/14      7:15           6270 list-hash-new-SHA256-hashes.txt
-a----        2024/03/14      7:16           3026 list-hash-old-ImportHashes.txt
-a----        2024/03/14      7:16           3264 list-hash-old-MD5-hashes.txt
-a----        2024/03/14      7:16           3864 list-hash-old-SHA1-hashes.txt
-a----        2024/03/14      7:16           6270 list-hash-old-SHA256-hashes.txt
-a----        2024/03/14      8:34            196 list-ip-new.txt
-a----        2024/03/14      7:31            196 list-ip-old.txt
-a----        2024/03/14      7:20           2750 stack-logon-new.csv
-a----        2024/03/14      7:20           2750 stack-logon-old.csv
-a----        2024/03/14      7:21         755816 timelne-logon-new.csv
-a----        2024/03/14      7:21         755816 timelne-logon-old.csv
-a----        2024/03/14      7:23             81 timelne-partition-new.csv
-a----        2024/03/14      7:23             81 timelne-partition-old.csv
-a----        2024/03/14      7:24         109586 ttp-summary-new.csv
-a----        2024/03/14      7:24         109667 ttp-summary-old.csv
-a----        2024/03/14      7:24          26253 ttp-vis-new.json
-a----        2024/03/14      7:25          26362 ttp-vis-old.json

Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thank you!

@YamatoSecurity YamatoSecurity merged commit 1b58329 into main Mar 14, 2024
3 checks passed
@fukusuket fukusuket deleted the refactor-for-automagic-command branch March 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-s, --skipProgressBar option
3 participants