-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: apply Template method pattern for automagic command #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukusuket
changed the title
refactor: apply template method pattern for automagic command
refactor: apply Template method pattern for automagic command
Mar 13, 2024
Closed
TestEnvironment
I also confirmed that there are no differences by comparing the following command with v2.4.0 on Windows.
|
hitenkoku
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YamatoSecurity
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket LGTM! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
New Feature
-s, --skipProgressBar
option #121Refactoring
automagic
command #132automagic
commandautomagic
as belowautomagic
command is commented out in this PR. I will create another PR forautomagic
.AbstractCmd
and create a subclass for each command and implementfilter/analyze/resultOutput
methodIntegration-Test
I confirmed that the integration test is successful as shown below.
https://github.com/Yamato-Security/takajo/actions/runs/8267602168
also I confirmed that the progress bar is not displayed when the -s option is added.
Test
Environment
Sorry for the PR with a lot of commits...
I would appreciate it if you could check it out when you have time🙏