Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate process output sysmon-process-tree #52

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Oct 9, 2023

What Changed

Test

Environment

  • OS: macOS Sonoma version 14.0
% nim -v
Nim Compiler Version 2.0.0 [MacOSX: amd64]
% nimble -v
nimble v0.14.2 compiled at 2023-08-19 16:19:52

Test1

Duplicate processes are not displayed in the steps to reproduce #51

% ./takajo sysmon-process-tree -t sample.jsonl -p 747F3D96-B7A5-5EA4-0000-0010EAB91300
...

C:\Windows\System32\smss.exe (2020-04-26 07:19:20.134 +09:00 / 300 / 747F3D96-B75F-5EA4-0000-0010622C0000 / 747F3D96-B75F-5EA4-0000-0010EB030000)
  └ C:\Windows\System32\smss.exe (2020-04-26 07:19:22.596 +09:00 / 388 / 747F3D96-B763-5EA4-0000-00106A480000 / 747F3D96-B75F-5EA4-0000-0010622C0000)
      └ C:\Windows\System32\wininit.exe (2020-04-26 07:19:23.222 +09:00 / 468 / 747F3D96-B764-5EA4-0000-0010904D0000 / 747F3D96-B763-5EA4-0000-00106A480000)
          └ C:\Windows\System32\services.exe (2020-04-26 07:19:24.049 +09:00 / 584 / 747F3D96-B764-5EA4-0000-00106F550000 / 747F3D96-B764-5EA4-0000-0010904D0000)
              └ C:\Windows\System32\svchost.exe (2020-04-26 07:19:40.692 +09:00 / 6964 / 747F3D96-B776-5EA4-0000-0010A74D0B00 / 747F3D96-B764-5EA4-0000-00106F550000)
                  └ C:\Windows\System32\consent.exe (2020-04-26 07:20:21.263 +09:00 / 7036 / 747F3D96-B7A5-5EA4-0000-0010EAB91300 / 747F3D96-B776-5EA4-0000-0010A74D0B00)

I found issue #51 during testing, but I think it would be better to fix it in a separate pull request.
I would appreciate it if you could review when you have time🙏

@fukusuket fukusuket self-assigned this Oct 9, 2023
@fukusuket fukusuket added the bug Something isn't working label Oct 9, 2023
@fukusuket fukusuket marked this pull request as ready for review October 9, 2023 12:36
Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket Thank you! I confirmed that it fixes the bug where info is outputted twice. LGTM.

@YamatoSecurity YamatoSecurity merged commit 9383781 into main Oct 10, 2023
2 checks passed
@fukusuket fukusuket deleted the fix-duplicate-process-output branch October 10, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] sysmon-process-tree outputs duplicate processes
3 participants