Removed all jshint comments. (prebid#1315)

Yann-Pravo · Jul 6, 2017 · 6302608 · 6302608
1 parent 6a7c95e
commit 6302608
Show file tree

Hide file tree

Showing 14 changed files with 6 additions and 23 deletions.
diff --git a/src/adaptermanager.js b/src/adaptermanager.js
@@ -108,7 +108,7 @@ exports.callBids = ({adUnits, cbTimeout}) => {
     });
 
     let s2sBidRequest = {tid, 'ad_units': adUnitsCopy};
-    let s2sAdapter = _bidderRegistry[_s2sConfig.adapter]; // jshint ignore:line
+    let s2sAdapter = _bidderRegistry[_s2sConfig.adapter];
     utils.logMessage(`CALLING S2S HEADER BIDDERS ==== ${adaptersServerSide.join(',')}`);
     s2sAdapter.setConfig(_s2sConfig);
     s2sAdapter.callBids(s2sBidRequest);

diff --git a/src/adapters/getintent.js b/src/adapters/getintent.js
@@ -1,5 +1,3 @@
-/* jshint loopfunc: true */
-
 import { STATUS } from 'src/constants';
 
 var bidfactory = require('../bidfactory.js');

diff --git a/src/adapters/indexExchange.js b/src/adapters/indexExchange.js
@@ -1,5 +1,4 @@
 // Factory for creating the bidderAdaptor
-// jshint ignore:start
 var utils = require('../utils.js');
 var bidfactory = require('../bidfactory.js');
 var bidmanager = require('../bidmanager.js');
@@ -140,7 +139,7 @@ window.headertag_render = function(doc, targetID, slotID) {
 
 window.cygnus_index_args = {};
 
-var cygnus_index_adunits = [[728, 90], [120, 600], [300, 250], [160, 600], [336, 280], [234, 60], [300, 600], [300, 50], [320, 50], [970, 250], [300, 1050], [970, 90], [180, 150]]; // jshint ignore:line
+var cygnus_index_adunits = [[728, 90], [120, 600], [300, 250], [160, 600], [336, 280], [234, 60], [300, 600], [300, 50], [320, 50], [970, 250], [300, 1050], [970, 90], [180, 150]];
 
 var getIndexDebugMode = function() {
   return getParameterByName(CONSTANTS.INDEX_DEBUG_MODE.queryParam).toUpperCase();

diff --git a/src/adapters/lifestreet.js b/src/adapters/lifestreet.js
@@ -82,7 +82,6 @@ const LifestreetAdapter = function LifestreetAdapter() {
             slotTagParams[property] = bid.params[property];
           }
         }
-        /* jshint newcap: false */
         LSM_Slot(slotTagParams);
         window.addEventListener('message', (ev) => {
           let key = ev.message ? 'message' : 'data';

diff --git a/src/adapters/nginad.js b/src/adapters/nginad.js
@@ -137,7 +137,6 @@ var NginAdAdapter = function NginAdAdapter() {
       var id = nginadBid.impid;
 
       // try to fetch the bid request we sent NginAd
-      /* jshint -W083 */
       var bidObj = $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === 'nginad').bids
         .find(bid => bid.bidId === id);
       if (!bidObj) {

diff --git a/src/adapters/pubmatic.js b/src/adapters/pubmatic.js
@@ -127,7 +127,7 @@ var PubmaticAdapter = function PubmaticAdapter() {
         adResponse.bidderCode = 'pubmatic';
         adResponse.adSlot = bid.adSlot;
         adResponse.cpm = Number(adUnitInfo.bid);
-        adResponse.ad = unescape(adUnit.creative_tag);  // jshint ignore:line
+        adResponse.ad = unescape(adUnit.creative_tag);
         adResponse.ad += utils.createTrackPixelIframeHtml(decodeURIComponent(adUnit.tracking_url));
         adResponse.width = dimensions[0];
         adResponse.height = dimensions[1];

diff --git a/src/polyfill.js b/src/polyfill.js
@@ -1,7 +1,6 @@
 /** @module polyfill
 Misc polyfills
 */
-/* jshint -W121 */
 require('core-js/fn/array/find');
 require('core-js/fn/array/includes');
 require('core-js/fn/object/assign');

diff --git a/src/utils.js b/src/utils.js
@@ -340,7 +340,7 @@ exports.isNumber = function(object) {
 exports.isEmpty = function (object) {
   if (!object) return true;
   if (this.isArray(object) || this.isStr(object)) {
-    return !(object.length > 0); // jshint ignore:line
+    return !(object.length > 0);
   }
 
   for (var k in object) {

diff --git a/test/spec/adapters/adform_spec.js b/test/spec/adapters/adform_spec.js
@@ -1,5 +1,3 @@
-// jshint esversion: 6
-
 import { assert } from 'chai';
 import * as utils from '../../../src/utils';
 import adLoader from '../../../src/adloader';

diff --git a/test/spec/adapters/criteo_spec.js b/test/spec/adapters/criteo_spec.js
@@ -1,5 +1,3 @@
-/* jshint -W030 */
-
 import Adapter from '../../../src/adapters/criteo';
 import bidManager from '../../../src/bidmanager';
 import {ajax} from '../../../src/ajax'

diff --git a/test/spec/adapters/inneractive_spec.js b/test/spec/adapters/inneractive_spec.js
@@ -122,7 +122,7 @@ describe('InneractiveAdapter', function () {
         delete bidRequest.bids;
         adapter.callBids(bidRequest);
 
-        expect(bidRequests).to.be.empty; // jshint ignore:line
+        expect(bidRequests).to.be.empty;
       });
     });
 
@@ -133,7 +133,7 @@ describe('InneractiveAdapter', function () {
         adapter.callBids(bidRequest);
 
         for (let id = 0; id < INVALID_BIDS_COUNT; id++) {
-          expect(adapter._isValidRequest.getCall(id).returned(false)).to.be.true; // jshint ignore:line
+          expect(adapter._isValidRequest.getCall(id).returned(false)).to.be.true;
         }
 
         adapter._isValidRequest.restore();

diff --git a/test/spec/adapters/serverbid_spec.js b/test/spec/adapters/serverbid_spec.js
@@ -1,6 +1,3 @@
-/* jshint -W024 */
-/* jshint expr:true */
-
 import { expect } from 'chai';
 import Adapter from 'src/adapters/serverbid';
 import bidmanager from 'src/bidmanager';

diff --git a/test/spec/adapters/underdogmedia_spec.js b/test/spec/adapters/underdogmedia_spec.js
@@ -1,5 +1,3 @@
-/* jshint -W030 */
-
 import Adapter from '../../../src/adapters/underdogmedia';
 import bidManager from '../../../src/bidmanager';
 import adloader from '../../../src/adloader';

diff --git a/test/spec/adapters/yieldbot_spec.js b/test/spec/adapters/yieldbot_spec.js
@@ -42,7 +42,6 @@ const YB_BID_FIXTURE = {
 };
 
 function createYieldbotMockLib() {
-  // jshint unused:false
   window.yieldbot = {
     _initialized: false,
     pub: (psn) => {},
@@ -54,7 +53,6 @@ function createYieldbotMockLib() {
       return YB_BID_FIXTURE[slotName] || {ybot_ad: 'n'};
     }
   };
-  // jshint unused:true
 }
 
 function restoreYieldbotMockLib() {