Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Identifier Completion Suggestion & Tokeniser Edge Cases #22

Closed
CullieM opened this issue May 17, 2021 · 4 comments
Closed

Identifier Completion Suggestion & Tokeniser Edge Cases #22

CullieM opened this issue May 17, 2021 · 4 comments
Assignees
@CullieM

Comments

@CullieM
Copy link
Collaborator

CullieM commented May 17, 2021

No description provided.

@CullieM CullieM self-assigned this May 17, 2021
@CullieM
Copy link
Collaborator Author

CullieM commented May 17, 2021

/cib

@create-issue-branch
Copy link

Branch 22-Identifier-Completion-Suggestion-Tokeniser-Edge-Cases created!

@CullieM
Copy link
Collaborator Author

CullieM commented May 19, 2021

Issue within Monaco:
microsoft/monaco-editor#1850

Solutions from Issue:
https://github.com/elastic/kibana/blob/356e45f117be19ab56d08621253d40d1cb30cb13/packages/kbn-monaco/src/painless/completion_adapter.ts
https://gist.github.com/cnayan/23cfde150a83f33a5e4da3b59284ea2b
microsoft/pxt#8049

CullieM added a commit that referenced this issue May 23, 2021
@CullieM
#22 - Fixed identifier capitalisation
beb244e
CullieM added a commit that referenced this issue May 23, 2021
@CullieM
#22 - Symbols and numbers in states
6bb87ed 
Symbols and numbers have been added to options, interpolation. Options are now recoloured, subject to change. Added fix so that body and header delimiters must be on their own line. Fixed title tags to include whitespace between Title: and identifier.
CullieM added a commit that referenced this issue May 23, 2021
@CullieM
#22 - Fixed interpolation clash with symbols, hashtags
277c699
@CullieM
Copy link
Collaborator Author

CullieM commented May 24, 2021

Red Squiggles
microsoft/monaco-editor#284

AdamJScott pushed a commit that referenced this issue May 24, 2021
#11 #22 - GUI and error squiggly mvp
6eac8bf
CullieM added a commit that referenced this issue May 24, 2021
@CullieM
#22 - Tokeniser changed to match Theme
b461240
CullieM added a commit that referenced this issue May 24, 2021
@CullieM
#22 - New Tokeniser fixes
546b0a3
AdamJScott pushed a commit that referenced this issue May 24, 2021
#11 merge changes from #22
1e09948
CullieM added a commit that referenced this issue May 24, 2021
@CullieM
#22 - variable auto-complete example
962a45a
AdamJScott pushed a commit that referenced this issue May 24, 2021
#11 #22 - GUI changes + bold/etc tokeniser fix
92028dd 
regex in bold, italics and underline was too greedy, commented in the fix in yarnSpinnerMonarch.js line 128
CullieM added a commit that referenced this issue May 24, 2021
@CullieM
#22 - Remove parentheses, breaking space
76832f1
CullieM added a commit that referenced this issue May 25, 2021
@CullieM
#22 - Smart code generation for variables and titles.
924b2d8 
Currently only stores one of each, a variable and a title.
CullieM added a commit that referenced this issue May 25, 2021
@CullieM
#22 - Changed autocomplete types and lint fix.
8a3674b
CullieM added a commit that referenced this issue May 25, 2021
@CullieM
#22 - Added dialogue escaping, hashtag fix
c8628c3
CullieM added a commit that referenced this issue May 25, 2021
@CullieM
#22 - Hashtag fix 2:
a2e53e2
CullieM added a commit that referenced this issue May 25, 2021
@CullieM
#22 - Added testing file
f5b973c
CullieM added a commit that referenced this issue May 25, 2021
@CullieM
#22 - Smart Code Generation Done
6145669 
Also added support for numbers in identifiers.
@CullieM CullieM closed this as completed May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CullieM CullieM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CullieM