Mars yarn spec #305
Merged
Mars yarn spec #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have one or two concerns around some of the wording in these changes, but overall I think it will be easier to pull these changes and then make the tweaks to them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just PR into Tim's current work in
yarn-specso he can accept/reject as he pleases :)Still think this is missing maybe a section (or just a link to discussion elsewhere) about how YarnSpinner-Unity infers variable declarations so if someone wanted to write their own interpreter they could do the same, but probably still don't require it as part of the spec bc complex.
Also this has not taken into account more recent discussions or requests in #285 and is primarily a spell/grammar/clarity check.