This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
U/msingh/clusterman 812 cache kubernetes client creation #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmdfalk
approved these changes
Aug 17, 2023
nemacysts
approved these changes
Aug 17, 2023
| @@ -54,33 +54,36 @@ | |||
|
|
|||
|
|
|||
| class KubeApiClientWrapper: | |||
| _client = None | |||
There was a problem hiding this comment.
might be worth a comment here re: why this is a classvar now (just to make sure that we can figure out why we did this even if someone moves this line around or something and the git blame no longer points directly at this commit) :)
This was referenced Aug 17, 2023
Signed-off-by: Max Falk <gfalk@yelp.com>
Signed-off-by: Max Falk <gfalk@yelp.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with each call to reload_state , we create a new instance of k8s client object. This causes constant increase in memory.
This PR make k8s client part of class attribute which let us reuse the existing k8s client without need to create a new client every single time.
More details at: https://yelp.slack.com/archives/CA53K7S68/p1692279792012659