Port to docker lib #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use docker.APIClient as object to interface with.
dnephin
reviewed
Mar 6, 2018
docker_custodian/docker_autostop.py
Outdated
| @@ -95,6 +95,10 @@ def get_opts(args=None): | |||
| ) | |||
| opts = parser.parse_args(args=args) | |||
|
|
|||
| if len(sys.argv) < 2: | |||
| parser.print_help() | |||
| exit(0) | |||
There was a problem hiding this comment.
Hmm, I don't understand why this change is necessary. Nothing is reading sys.argv that I can see.
It should probably be exit(1) if help wasn't requested.
There was a problem hiding this comment.
dcstop prints a warning message/help w/o args.
dcgc prints nothing w/o args.
Seems a little inconsistent but no big deal.
You are right - nothing is broken.
I'll take the help msg out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates requirements.txt and makes use of the new 'docker' library that replaces 'docker-py'.
In addition, instead of crashing when no args are given, print the usage help.
You may want to cut a release without this change but include the dangling volume fix. Then cut another release with this change. Or just put them all together. Anyway, it'd be great if a new version got out there so we could start using it.
I don't have any other changes to docker-custodian at this time.
Thanks.