Clear scroll if not used anymore #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2019
| @@ -624,7 +625,8 @@ def run_query(self, rule, start=None, end=None, scroll=False): | |||
| pass | |||
|
|
|||
| if 'scroll_id' in rule: | |||
| rule.pop('scroll_id') | |||
| scroll_id = rule.pop('scroll_id') | |||
| self.current_es.clear_scroll(scroll_id=scroll_id) | |||
There was a problem hiding this comment.
@Qmando For clearing the es scroll, we have to send the scroll id in the body, i applied below change and my scroll is maintained at the max limit i set.
self.thread_data.current_es.clear_scroll(body={'scroll_id': scroll_id})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this commit elastic/elasticsearch@d27aa72 in elasticsearch. A scroll parallel limit of 500 is set.
This seems related to this issue : #2249
Elastalert create scroll for each research with default to 30s for keeping the scroll context alive.
But it never clears the scroll if it's not used anymore
As it's really easy to open 500 scroll in 30 seconds, the scroll should be clear after usage.