Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Twilio Copilot #2374

Closed
wants to merge 5 commits into from

Conversation

cdmastercom
Copy link

Per Twilio Docs add support for alerts using Copilot. Compability with the existing Twilio SMS alerting method is maintained.

  • Make 'twilio_from_number' optional
  • Add setting 'twilio_message_service_sid'
  • Add setting 'twilio_use_copilot', defaults to False

In case 'twilio_use_copilot' is False, 'twilio_from_number' is required. Otherwise, 'twilio_message_service_sid' is required.

I've tested this using an Elasticsearch 7.1.1 cluster, both SMS and Copilot alerting work.

Maintain compatibility with Twilio SMS API, validate new settings conditionally using the 'twilio_use_copilot' flag. Throws EAException in case of an incorrect combination of settings.
@nsano-rururu
Copy link
Contributor

nsano-rururu commented Apr 23, 2021

@cdmastercom
Any way you could push this PR to https://github.com/jertel/elastalert2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants