Fix more tests to work on a non yelp dev box #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| print 'Container info:\n%s' % container_info | ||
| assert len(container_info['ExecIDs']) == int(num) | ||
| print "Number of execs %d" % len(execs) |
There was a problem hiding this comment.
Heh. I don't know why in behave these asserts don't act like py.test asserts. I found it pretty difficult to get past "assertion failed" messages.
|
fix'n'ship |
solarkennedy
added a commit
that referenced
this pull request
Nov 4, 2015
Fix more tests to work on a non yelp dev box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensu team-data file is a yelpism that not everyone is going to have, so I think it needs to be optional.
The rest of the changes are related to making it work on more recent versions of docker with stock docker images.