Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasMessages does not work with attributes #26

Merged
merged 1 commit into from
Nov 19, 2022
Merged

HasMessages does not work with attributes #26

merged 1 commit into from
Nov 19, 2022

Conversation

Ygg01
Copy link
Owner

@Ygg01 Ygg01 commented Nov 18, 2022

  • Adds LinguiniBundle.HasAttrMessage method
  • Obsoletes LinguiniBundle.TryGetAttrMsg for LinguiniBundle.TryGetAttrMessage
  • Obsoletes LinguiniBundle.TryGetMsg for LinguiniBundle.TryGetMessage

Fixes #25

@Ygg01
Adds HasAttrMessage, and obsoletes TryGetAttrMsg and TryGetMsg.
ee4efa2 
- Adds `LinguiniBundle.HasAttrMessage` method
- Obsoletes `LinguiniBundle.TryGetAttrMsg` for `LinguiniBundle.TryGetAttrMessage`
- Obsoletes `LinguiniBundle.TryGetMsg` for `LinguiniBundle.TryGetMessage`
@Mailaender
Copy link
Contributor

Why AttrMsg to AttrMessage instead of AttributeMessage?

@Ygg01
Copy link
Owner Author

Ygg01 commented Nov 19, 2022

Why AttrMsg to AttrMessage instead of AttributeMessage?

Because I used Attr rather than Attribute consistently.

@Ygg01 Ygg01 merged commit 038a3c3 into master Nov 19, 2022
@Mailaender Mailaender mentioned this pull request Nov 19, 2022
Merged
@Ygg01 Ygg01 deleted the has-attr-message branch February 6, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mailaender Mailaender Mailaender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HasMessages does not work with attributes
2 participants
@Ygg01 @Mailaender