AMT: Fix One Click Recovery support #6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the curious and documentation, the boot UI looks like this on a Dell AIO |
|
Have read docs and all seems correct from what i can tell so will merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This PR fixes Intel AMT: One Click Recovery that is currently unusable due to an impossible condition. It also replace .iso (which is an unsupported format) to .efi to allow BIOS to load the file
You may need to squash commits included in this PR to keep it clean
It has been tested on a Dell Optiplex 7400 AIO (Intel AMT v16) and with iPXE(.efi) that can be found here: http://boot.ipxe.org/ipxe.efi
Interestingly enough, I came across Intel EMA code that do something similar, and there is a bug in its implementation of makeUefiBootParam() where the len argument is ignored, in the case of a number it'll always be 4 bytes. I'm asking myself if this difference would be volontary and better compatibility with more BIOS software
Feel free to ask any questions or modifications 👐