3.0 | Drop support for PHPUnit < 6.4 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust CI, README and `composer.json` for the drop of support for PHPUnit < 6.4.4. The 6.4.4 version is a deliberate choice to allow for dropping: * The `ExpectExceptionObject` polyfill (native method was introduced in PHPUnit 6.4.0 with bugfix in PHPUnit 6.4.4) * A work-around in the `AssertStringContains` polyfills for a bug which was fixed in PHPUnit 6.4.2. * And not requiring a call to `expectException()` for a call to `expectExceptionMessage()` (bug fixed in PHPUnit 6.4.3).
Remove the `ExpectExceptionObject` polyfill and all references to it.
As the minimum supported PHPUnit version will be PHPUnit 6.4.4, the `AssertStringContains` logic can be reverted to the original logic and no longer needs to account for the PHPUnit < 6.4.2 bug with `mb_strpos()`.
Even though the TestListener implementation is not (yet) compatible with PHPUnit 10 (nor 11), we should still drop support for PHPUnit < 6.4 from the existing implementation.
Remove work-arounds for PHPUnit 5.x from the test suite.
hellofromtonya
deleted the
feature/3.x/drop-support-for-phpunit-lt-64
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for PHPUnit < 6.4 [1]
Adjust CI, README and
composer.jsonfor the drop of support for PHPUnit < 6.4.4.The 6.4.4 version is a deliberate choice to allow for dropping:
ExpectExceptionObjectpolyfill (native method was introduced in PHPUnit 6.4.0 with bugfix in PHPUnit 6.4.4)AssertStringContainspolyfills for a bug which was fixed in PHPUnit 6.4.2.expectException()for a call toexpectExceptionMessage()(bug fixed in PHPUnit 6.4.3).Drop support for PHPUnit < 6.4 [2]
Remove the
ExpectExceptionObjectpolyfill and all references to it.Drop support for PHPUnit < 6.4 [3]
As the minimum supported PHPUnit version will be PHPUnit 6.4.4, the
AssertStringContainslogic can be reverted to the original logic and no longer needs to account for the PHPUnit < 6.4.2 bug withmb_strpos().Drop support for PHPUnit < 6.4 [4]
Even though the TestListener implementation is not (yet) compatible with PHPUnit 10 (nor 11), we should still drop support for PHPUnit < 6.4 from the existing implementation.
Drop support for PHPUnit < 6.4 [5]
Remove work-arounds for PHPUnit 5.x from the test suite.