PHPUnit 11 | Make select methods protected
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 11.0 changed the visibility of a number of `TestCase` methods from `public` to `protected`, so the PHPUnit Polyfills should follow suit. For the Polyfills, the only affected method is the polyfilled `expectExceptionMessageMatches()` method. Refs: * sebastianbergmann/phpunit 5213 * sebastianbergmann/phpunit@8b8e38e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 11.0 changed the visibility of a number of
TestCasemethods frompublictoprotected, so the PHPUnit Polyfills should follow suit.For the Polyfills, the only affected method is the polyfilled
expectExceptionMessageMatches()method.Refs:
TestCasemethodsprotectedthat should have beenprotectedall along sebastianbergmann/phpunit#5213