Release version 1.0.2 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `job` has builds which are allowed to `continue-on-error` and only those fail/error, the workflow will be marked as "passed" (green), but for any PR containing builds which failed, even though they are allowed to fail, the PR will still show an ❌. This is confusing and discouraging for people. Currently, there are two builds which are "allowed to fail": * A build against PHP 8.1. * A build against PHPUnit 10. As people are starting to test against PHP 8.1, if that build would start to fail, it needs to be looked at straight away. However, as PHPUnit 10.0 is still under heavy development and a release is still a while away, let's not let PRs be marked as failed, when that is the only build which is failing.
…ow-as-green-phpunit-10 GH Actions: selectively don't mark PRs as failed
Improve the code sample.
As of version 2.15.0 of the `shivammathur/setup-php` action for GitHub Actions, the PHPUnit Polyfills can be installed directly from this action using the `tools` key. In that case, both this package as well as PHPUnit will be globally installed via Composer. This commit adds an FAQ section to the readme with a little more information about how this works and how to get things running when installed like that.
README: various small updates / add FAQ about setup-php
Most notably, PHP Parallel Lint 1.3.1 has improved compatibility with PHP 8.1. Refs: * https://github.com/php-parallel-lint/PHP-Parallel-Lint/releases/tag/v1.3.1
Composer: update dev dependency
... which includes PHP Parallel Lint by design, so no need to require it separately anymore. Ref: https://github.com/Yoast/yoastcs/releases
* For camelCase object names which are not going to be changed being flagged. * For fixtures containing test methods being flagged. Those are not the real tests.
Update for YoastCS 2.2.0
Fix command name used to generate autoload files
PHPUnit just released version 9.5.10 and 8.5.21. This contains a particular (IMO breaking) change: > * PHPUnit no longer converts PHP deprecations to exceptions by default (configure `convertDeprecationsToExceptions="true"` to enable this) Let's unpack this: Previously (PHPUnit < 9.5.10/8.5.21), if PHPUnit would encounter a PHP native deprecation notice, it would: 1. Show a test which causes a deprecation notice to be thrown as **"errored"**, 2. Show the **first** deprecation notice it encountered and 3. PHPUnit would exit with a **non-0 exit code** (2), which will fail a CI build. As of PHPUnit 9.5.10/8.5.21, if PHPUnit encounters a PHP native deprecation notice, it will no longer do so. Instead PHPUnit will: 1. Show a test which causes a PHP deprecation notice to be thrown as **"risky"**, 2. Show the **all** deprecation notices it encountered and 3. PHPUnit will exit with a **0 exit code**, which will show a CI build as passing. This commit reverts PHPUnit to the previous behaviour by adding `convertDeprecationsToExceptions="true"` to the PHPUnit configuration.
PHPUnit: update configuration
The build against PHP 8.1 has been passing for a while and it should stay that way.
... but allow for the builds to fail.
…allowed-to-fail GH Actions: adjust matrix - add PHP 8.2, PHP 8.1 not allowed to fail
The version check in the `Autoload::loadTestCase()` method could get confused if the package using this library, or a dependency of the package using this library would alias the `PHPUnit_Runner_Version`/`PHPUnit\Runner\Version` class. As both classes contain the method we need to retrieve the version number, let's always base the loading on the available PHPUnit version number instead of the availability of either class.
Autoload: improve/stabilize version check for TestCase
Includes updating the `VERSION` constant in the `Autoload` class.
Changelog for the 1.0.2 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional:
VERSIONconstant in thephpunitpolyfills-autoload.phpfile. PR Changelog for the 1.0.2 release #60Release:
Verify that a release link at the bottom of the
CHANGELOG.mdfile has been added.develop!).develop!) & copy & paste the changelog to it.Make sure to copy the links to the issues and the links to the GH usernames from the bottom of the changelog!
Announce: