Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

add multiple boolean? to sidebarSelect attributes #1110

Merged

Conversation

increddibelly
Copy link
Contributor

@increddibelly increddibelly commented Mar 18, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [schema-blocks] Fixes a bug where a sidebar select would not allow multiple selections.

Relevant technical choices:

  • add multiple boolean field to the attribute definition and set default value

Test instructions

This PR can be tested by following these steps:

  • we don't have any blocks yet with a sidebar select; this bug prevented the schema blocks package from being compiled. That problem is now gone.
  • You could add a sidebarselect block to a recipe template, but the actual functionality of the sidebar select control has never been tested and is out of scope for this ticket.

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@increddibelly increddibelly added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation labels Mar 18, 2021
@increddibelly increddibelly added this to the 16.1 milestone Mar 18, 2021
Copy link
Contributor

@hansjovis hansjovis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 👍

@hansjovis
Copy link
Contributor

Acceptance test: ✅

  • Package can be built.
  • Tests pass.
  • CS is okay.

Waiting for Travis to pass.

@hansjovis hansjovis merged commit 10a27ee into develop Mar 18, 2021
@hansjovis hansjovis deleted the P2-757-TypeScript_error_in_SidebarSelect_instruction branch March 18, 2021 09:57
@johannadevos johannadevos modified the milestones: 16.1, 16.2 Mar 22, 2021
@johannadevos johannadevos added changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog innovation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants