Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Allow custom labels to be used in the replacement variable editor #1114

Merged
merged 5 commits into from
Mar 23, 2021

Conversation

jcomack
Copy link
Contributor

@jcomack jcomack commented Mar 19, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [replacement-variable-editor] Adds possibility to pass alternative labels for the SEO title and Meta description fields in the SettingsSnippetEditor.

Relevant technical choices:

  • This PR introduces a change that will be used in Yoast SEO. Testing this change can be done based on the PR that will be made in the plugin and this PR only 'enables' the possibility.

Test instructions

This PR can be tested by following these steps:

  • Checkout this branch and build accordingly.
  • Use yarn link-monorepo to link the entire monorepo to your local Yoast SEO installation.
  • Ensure your Yoast SEO installation is fully built (composer install, yarn, grunt build).
  • Navigate to SEO -> Search Appearance -> Content Types.
  • See that nothing has changed in the forms and the usual SEO title and Meta description labels are still present. This means that the default values are properly working.

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Required for Yoast/wordpress-seo#16806

@jcomack jcomack added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Mar 19, 2021
@jcomack jcomack changed the title P3 418 snippet editor fields Allow custom labels to be used in the replacement variable editor Mar 19, 2021
Copy link
Member

@enricobattocchi enricobattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR OK!

@afercia afercia added this to the 16.2 milestone Mar 23, 2021
@afercia
Copy link
Contributor

afercia commented Mar 23, 2021

Acceptance 👍

@afercia afercia merged commit 7c7d0fd into develop Mar 23, 2021
@afercia afercia deleted the P3-418-snippet-editor-fields branch March 23, 2021 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants