Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

P2 694 create schema blocks redux store #1119

Merged
merged 12 commits into from
Mar 30, 2021

Conversation

increddibelly
Copy link
Contributor

@increddibelly increddibelly commented Mar 25, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/schema-blocks] creates a redux store for schema blocks .

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • add any yoast block; this will trigger validation, which should be stored in redux.
  • use the redux DevTools to analyze the yoast/schema-blocks store, the validation results should be there.
    image
  • there should not be any console errors related to the actions e.g. cannot find property getSchemaBlocksValidationResults of undefined

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@increddibelly increddibelly modified the milestones: 16.2, 16.3 Mar 25, 2021
@increddibelly increddibelly added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation labels Mar 25, 2021
@increddibelly increddibelly marked this pull request as ready for review March 25, 2021 10:20
Copy link
Contributor

@andizer andizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@johannadevos
Copy link
Contributor

Acceptance: 🚧

  • I see validation results for the Job Posting block in the yoast-seo/schema-blocks store.
  • I see no console errors related to this PR.
  • When I add other blocks, for example the Yoast Estimated Reading Time block, but also for example a Core Paragraph block, their 'validation' also appears in the store, in the BlockValidationResult type. Is this desired behavior?

Screenshot 2021-03-30 at 13 55 01

  • The Schema Blocks validations are still present in the yoast-seo/editor store. I would have not expected them to be there anymore.

Screenshot 2021-03-30 at 13 56 46

  • On this branch, but not on develop and trunk (in Free), the yoast-seo/editor and the yoast-seo-premium/editor store are loaded twice when adding the Job Posting block.

Screenshot 2021-03-30 at 13 58 17

@johannadevos johannadevos removed this from the 16.3 milestone Mar 30, 2021
…ma-blocks-redux-store

# Conflicts:
#	packages/schema-blocks/src/functions/presenters/SidebarWarningPresenter.ts
#	packages/schema-blocks/src/index.ts
@increddibelly increddibelly merged commit 050d7d6 into develop Mar 30, 2021
@increddibelly increddibelly deleted the P2-694-create-schema-blocks-redux-store branch March 30, 2021 14:27
@increddibelly increddibelly added this to the 16.2 milestone Apr 6, 2021
@johannadevos johannadevos removed the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 8, 2021
@johannadevos johannadevos added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog innovation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants