This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
P2 694 create schema blocks redux store #1119
Merged
increddibelly
merged 12 commits into
develop
from
P2-694-create-schema-blocks-redux-store
Mar 30, 2021
Merged
P2 694 create schema blocks redux store #1119
increddibelly
merged 12 commits into
develop
from
P2-694-create-schema-blocks-redux-store
Mar 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abotteram
reviewed
Mar 25, 2021
packages/schema-blocks/src/functions/redux/SchemaBlocksAction.ts
Outdated
Show resolved
Hide resolved
abotteram
reviewed
Mar 25, 2021
packages/schema-blocks/src/functions/redux/actions/schemaBlocks.ts
Outdated
Show resolved
Hide resolved
abotteram
reviewed
Mar 25, 2021
packages/schema-blocks/src/functions/redux/reducer/schemaBlocks.ts
Outdated
Show resolved
Hide resolved
abotteram
reviewed
Mar 25, 2021
increddibelly
added
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
innovation
labels
Mar 25, 2021
…ma-blocks-redux-store
…ma-blocks-redux-store # Conflicts: # packages/schema-blocks/src/functions/presenters/SidebarWarningPresenter.ts
5 tasks
andizer
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍
…-694-create-schema-blocks-redux-store
Acceptance: 🚧
|
…ma-blocks-redux-store # Conflicts: # packages/schema-blocks/src/functions/presenters/SidebarWarningPresenter.ts # packages/schema-blocks/src/index.ts
…hub.com/Yoast/javascript into P2-694-create-schema-blocks-redux-store
johannadevos
removed
the
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
label
Apr 8, 2021
johannadevos
added
the
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
label
Apr 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
innovation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
cannot find property getSchemaBlocksValidationResults of undefined
Impact check
*
UI changes
Quality assurance
Fixes #